-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measurement unit isn't updated in admin panel #17
Comments
You're great at spotting the details - really appreciate that. It will only take a few minutes to fix this and the other issue you raised but I'm busy with some major improvements to the content management side of things so won't be able to do it right away. Will update this issue as soon as I get the chance to fix it. |
No worries man. I'd try to fix them myself but I'm not a ruby dev. I got the thing running on heroku but can't figure out how to deploy updates from github to heroku. Still learning |
On the heroku dashboard for your app, there is a deploy page. In there you will see a section that allows you to "deploy a github branch". If you set that up and click the button it will do an update. |
Yeah I'm working on it. It failed using the 'property_web_builder' repo, gonna try next with the 'pwb_for_heroku' repo. I guess I'd need to change some Gemfiles in there to point to my copy of it though? |
Yeah, you want the pwb_for_heroku repo. Should work without any changes. |
Yeah but so if I make a fix in my fork, then to test it I should change the Gemfile and Gemfile.lock within the |
If you are deploying your own fork, don't use the "Deploy to Heroku" button - that is coded to use the main "pwb_for_heroku" repo. |
Hi @mmikeww, hope deploying updates to heroku worked for you. The original issue raised here has been resolved so I'm going to close this. |
Its impossible to view the diff because of the minified javascript... perhaps the code in the repo should be saved in readable form and then minified during the build/deploy? |
I ask, because I'm not seeing the fixes when I depoy to heroku, and I'm having a hard time inspecting the diff |
Yes, it's not possible to figure out the javascript for the admin panel right now. I aim to restructure the code soon to include a readable form of it in the main project. |
Sorry I'm new to heroku... I hadn't updated the gemfile in the pwb-for-heroku repository and that's why I wasn't seeing the changes! |
Ah cool, glad you got it working ;) |
http://imgur.com/a/NyjhA
The text was updated successfully, but these errors were encountered: