Skip to content

Polish the "Container Engine" document #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 137 commits into from
Jun 5, 2025
Merged

Polish the "Container Engine" document #130

merged 137 commits into from
Jun 5, 2025

Conversation

@gwangmu
Copy link
Contributor

@gwangmu gwangmu commented Jun 3, 2025 •
edited
Loading

This PR polishes the document on "Container Engine."

  • Update the content to be up to date with the Confluence counterpart.
  • Split the document into multiple child pages (for readability).

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

gwangmu and others added 2 commits June 5, 2025 11:20
@gwangmu @bcumming
Update docs/index.md
c882e01 
Co-authored-by: Ben Cumming <bcumming@cscs.ch>
@gwangmu @msimberg
Update docs/software/container-engine/edf.md
d7833e7 
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@gwangmu
Copy link
Contributor Author

gwangmu commented Jun 5, 2025

@msimberg @bcumming Thank you all for helpful comments! I addressed all of them and uploaded them to this PR. Please let me know if I missed any comments.

@gwangmu gwangmu requested review from bcumming and msimberg June 5, 2025 09:28
msimberg
msimberg approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I'll defer merging to @RMeli or @bcumming if they are also happy.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

preview available: https://docs.tds.cscs.ch/130

@gwangmu
Copy link
Contributor Author

gwangmu commented Jun 5, 2025

I slightly corrected one section of the EDF reference. I apologize for the last-minute change.

@bcumming bcumming merged commit 071fdea into eth-cscs:main Jun 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msimberg msimberg msimberg approved these changes

@bcumming bcumming bcumming approved these changes

@RMeli RMeli Awaiting requested review from RMeli RMeli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gwangmu @msimberg @bcumming