Skip to content

Updating Jupyter docs with feedback from summer school in Heilbronn #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 7, 2025
Merged

Updating Jupyter docs with feedback from summer school in Heilbronn #172

merged 26 commits into from
Jul 7, 2025

Conversation

@lukasgd
Copy link
Contributor

@lukasgd lukasgd commented Jul 1, 2025

No description provided.

@lukasgd lukasgd requested review from boeschf and henrique July 1, 2025 11:25
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@lukasgd lukasgd requested a review from twrobinson July 1, 2025 11:42
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

RMeli
RMeli reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments and nitpicks. It might be worth to merge this before tomorrow's course.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@lukasgd @RMeli
Update docs/access/jupyterlab.md
f34b400 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

lukasgd and others added 2 commits July 1, 2025 15:38
@lukasgd @RMeli
Update docs/access/jupyterlab.md
7a37b52 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@lukasgd @RMeli
Update docs/access/jupyterlab.md
b580e26 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@lukasgd @RMeli
Update docs/access/jupyterlab.md
dcb554a 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@lukasgd @RMeli
Update docs/access/jupyterlab.md
6695447 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

lukasgd and others added 2 commits July 1, 2025 15:40
@lukasgd @RMeli
Update docs/access/jupyterlab.md
7543dcd 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@lukasgd @RMeli
Update docs/access/jupyterlab.md
c1b1923 
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

2 similar comments
@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

msimberg
msimberg reviewed Jul 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

msimberg
msimberg reviewed Jul 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

msimberg
msimberg reviewed Jul 7, 2025
View reviewed changes
msimberg
msimberg reviewed Jul 7, 2025
View reviewed changes
msimberg
msimberg reviewed Jul 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

2 similar comments
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/172

msimberg
msimberg approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukasgd. Let's go with this as it is. @rsarm et al. please comment/open follow-up PRs even after merging if you think there's something that could be changed.

@msimberg msimberg added this pull request to the merge queue Jul 7, 2025
Merged via the queue into eth-cscs:main with commit 602f4aa Jul 7, 2025
1 check passed
twrobinson
twrobinson approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@twrobinson twrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge. Further changes can be made as this is a living implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RMeli RMeli RMeli left review comments

@msimberg msimberg msimberg approved these changes

@twrobinson twrobinson twrobinson approved these changes

@henrique henrique Awaiting requested review from henrique

@boeschf boeschf Awaiting requested review from boeschf

@rsarm rsarm Awaiting requested review from rsarm rsarm is a code owner

@bcumming bcumming Awaiting requested review from bcumming bcumming is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukasgd @msimberg @twrobinson @RMeli @bcumming