Skip to content

Conversation

@msimberg
Copy link
Collaborator

@msimberg msimberg commented Apr 3, 2025

I've attempted to fix up some code blocks. Whatever was obviously a terminal (ehm, console) session I've updated to use console. Turns out terminal isn't a valid lexer, and just does no highlighting. I've changed some types to bash or console a bit depending on the contents of the code block, but I have not tried to fix everything.

I've added a section about code blocks to the style guide, which we can try to follow when updating existing or adding new docs.

msimberg added 2 commits April 3, 2025 09:52
- Use console instead of terminal
- Use bash when there's no output
@msimberg msimberg self-assigned this Apr 3, 2025
@msimberg msimberg requested review from RMeli and bcumming as code owners April 3, 2025 08:09
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

preview available: https://docs.tds.cscs.ch/74

@msimberg msimberg mentioned this pull request Apr 3, 2025
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
My only suggested improvement is to document the use of $ for "user prompt" in console/bash examples.

Co-authored-by: Ben Cumming <bcumming@cscs.ch>
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

preview available: https://docs.tds.cscs.ch/74

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

preview available: https://docs.tds.cscs.ch/74

@msimberg msimberg requested a review from bcumming April 3, 2025 09:16
@bcumming bcumming merged commit 56195c9 into eth-cscs:main Apr 3, 2025
1 check passed
@RMeli
Copy link
Member

RMeli commented Apr 3, 2025

Thanks @msimberg!

@msimberg msimberg deleted the code-blocks branch April 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants