Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well Done, Can you Explain? with comments in code and here How did you Solve it? #1

Closed
wis opened this issue Oct 16, 2016 · 2 comments

Comments

@wis
Copy link

wis commented Oct 16, 2016

also Why rely on Unity as a dependency, can it be done in other way?
ASP.NET Core has built-in support for constructor-based dependency injection.
I know this just simple .Net Core project.

@wis wis changed the title Well Done, Can you Explain? via comments in code and here How did you Solve it? Well Done, Can you Explain? with comments in code and here How did you Solve it? Oct 16, 2016
@ethanli83
Copy link
Owner

Hi @wesamco,

I have updated the readme with some explanations and sample codes. Let me if it helps.

For the question of using UnityContainer. Yes, it can be done by any container of your choice. In fact, neither the sample code nor graphql-dot-net is really depending on a partially container, so you can use whatever is more appropriate for you.

I used UnityContainer just because I am more familiar with it, and it is good enough for a console program. For an ASP.NET app, the one provided by ASP.NET Core is definitely more suitable.

@ethanli83
Copy link
Owner

Hi @wesamco,

I will close this one for now, if you have any question, feel free to reopen this one or create another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants