From 74ee1a294fee1cbdfd437eeee70cdc6176a17363 Mon Sep 17 00:00:00 2001 From: Ethan Moffat Date: Tue, 1 Mar 2022 21:40:31 -0800 Subject: [PATCH] Fix sign extension issue when encoding 2-byte number for packets. Converting short back to ushort before it gets extended to int fixes the problem. --- EOLib/Net/PacketBuilder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EOLib/Net/PacketBuilder.cs b/EOLib/Net/PacketBuilder.cs index cfb1febf1..94e615e89 100644 --- a/EOLib/Net/PacketBuilder.cs +++ b/EOLib/Net/PacketBuilder.cs @@ -67,7 +67,7 @@ public IPacketBuilder AddChar(byte b) public IPacketBuilder AddShort(short s) { - return AddBytes(_encoderService.EncodeNumber(s, 2)); + return AddBytes(_encoderService.EncodeNumber((ushort)s, 2)); } public IPacketBuilder AddThree(int t)