diff --git a/EOLib/Domain/Account/AccountActions.cs b/EOLib/Domain/Account/AccountActions.cs index db9159747..e6e19a7bb 100644 --- a/EOLib/Domain/Account/AccountActions.cs +++ b/EOLib/Domain/Account/AccountActions.cs @@ -91,7 +91,7 @@ public async Task CheckAccountNameWithServer(string accountName) public async Task CreateAccount(ICreateAccountParameters parameters, short sessionID) { var createAccountPacket = new PacketBuilder(PacketFamily.Account, PacketAction.Create) - .AddShort((ushort)sessionID) + .AddShort(sessionID) .AddByte(255) .AddBreakString(parameters.AccountName) .AddBreakString(parameters.Password) diff --git a/EOLib/Net/Connection/NetworkConnectionActions.cs b/EOLib/Net/Connection/NetworkConnectionActions.cs index 5327cfebd..77b0917b4 100644 --- a/EOLib/Net/Connection/NetworkConnectionActions.cs +++ b/EOLib/Net/Connection/NetworkConnectionActions.cs @@ -114,7 +114,7 @@ public void CompleteHandshake(IInitializationData initializationData) var packet = new PacketBuilder(PacketFamily.Connection, PacketAction.Accept) .AddShort((short)initializationData[InitializationDataKey.SendMultiple]) .AddShort((short)initializationData[InitializationDataKey.ReceiveMultiple]) - .AddShort((ushort)_playerInfoRepository.PlayerID) + .AddShort(_playerInfoRepository.PlayerID) .Build(); _packetSendService.SendPacket(packet); diff --git a/EOLib/Net/FileTransfer/FileRequestService.cs b/EOLib/Net/FileTransfer/FileRequestService.cs index 1575897fe..5b8ae1a1c 100644 --- a/EOLib/Net/FileTransfer/FileRequestService.cs +++ b/EOLib/Net/FileTransfer/FileRequestService.cs @@ -30,7 +30,7 @@ public async Task RequestMapFile(short mapID, short sessionID) { var request = new PacketBuilder(PacketFamily.Welcome, PacketAction.Agree) .AddChar((byte)InitFileType.Map) - .AddShort((ushort)sessionID) + .AddShort(sessionID) .AddShort(mapID) .Build(); @@ -41,7 +41,7 @@ public async Task RequestMapFileForWarp(short mapID, short sessionID) { var request = new PacketBuilder(PacketFamily.Warp, PacketAction.Take) .AddShort(mapID) - .AddShort((ushort)sessionID) + .AddShort(sessionID) .Build(); return await GetMapFile(request, mapID); @@ -52,7 +52,7 @@ public async Task> RequestFile(InitFileType fileType, { var request = new PacketBuilder(PacketFamily.Welcome, PacketAction.Agree) .AddChar((byte)fileType) - .AddShort((ushort)sessionID) + .AddShort(sessionID) .AddChar(1) // file id (for chunking oversize pub files) .Build(); diff --git a/EOLib/Net/IPacketBuilder.cs b/EOLib/Net/IPacketBuilder.cs index b546873d6..78fa5dd86 100644 --- a/EOLib/Net/IPacketBuilder.cs +++ b/EOLib/Net/IPacketBuilder.cs @@ -22,8 +22,6 @@ public interface IPacketBuilder IPacketBuilder AddShort(short s); - IPacketBuilder AddShort(ushort s); - IPacketBuilder AddThree(int t); IPacketBuilder AddInt(int i); diff --git a/EOLib/Net/PacketBuilder.cs b/EOLib/Net/PacketBuilder.cs index 721527717..94e615e89 100644 --- a/EOLib/Net/PacketBuilder.cs +++ b/EOLib/Net/PacketBuilder.cs @@ -67,12 +67,7 @@ public IPacketBuilder AddChar(byte b) public IPacketBuilder AddShort(short s) { - return AddBytes(_encoderService.EncodeNumber(s, 2)); - } - - public IPacketBuilder AddShort(ushort s) - { - return AddBytes(_encoderService.EncodeNumber(s, 2)); + return AddBytes(_encoderService.EncodeNumber((ushort)s, 2)); } public IPacketBuilder AddThree(int t) diff --git a/EOLib/PacketHandlers/BeginPlayerWarpHandler.cs b/EOLib/PacketHandlers/BeginPlayerWarpHandler.cs index b05ec4562..c836f13fc 100644 --- a/EOLib/PacketHandlers/BeginPlayerWarpHandler.cs +++ b/EOLib/PacketHandlers/BeginPlayerWarpHandler.cs @@ -88,7 +88,7 @@ private void SendWarpAcceptToServer(short mapID, short sessionID) { var response = new PacketBuilder(PacketFamily.Warp, PacketAction.Accept) .AddShort(mapID) - .AddShort((ushort)sessionID) + .AddShort(sessionID) .Build(); _packetSendService.SendPacket(response); }