Windows Package crashes on viewing "Plugin manager" #2094

Closed
BestWillInTheWorld opened this Issue Feb 21, 2014 · 2 comments

Comments

Projects
None yet
3 participants

Windoes package errors and exits the server when the "plugin manager" under admin (http://127.0.0.1:9001/admin/plugins) is viewed (simple auth completed for an admin user).

Blows up when data.versions is a non-object and quits:
"TypeError: Object.keys called on non-object"

Bug found in:
~\etherpad-lite-win\node_modules\ep_etherpad-lite\node_modules\npm\lib\search.js
line 89

Was:

     , version: Object.keys(data.versions)[0] || []

My local fix:

     , version: Object.keys(data.versions || {})[0] || []

I'm not set up Git-wise yet, so can't offer any direct contribution yet & can't see the Windows Package anywhere in the Repo...
Update:
The bug isn't present in the current npm version, so I'd guess the Windows Package just needs npm source updating?

gonium commented Feb 22, 2014

Confirmed. The proposed patch above worked for me.

Owner

marcelklehr commented Feb 26, 2014

npm is up-to-date now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment