New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Package crashes on viewing "Plugin manager" #2094

Closed
BestWillInTheWorld opened this Issue Feb 21, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@BestWillInTheWorld

BestWillInTheWorld commented Feb 21, 2014

Windoes package errors and exits the server when the "plugin manager" under admin (http://127.0.0.1:9001/admin/plugins) is viewed (simple auth completed for an admin user).

Blows up when data.versions is a non-object and quits:
"TypeError: Object.keys called on non-object"

Bug found in:
~\etherpad-lite-win\node_modules\ep_etherpad-lite\node_modules\npm\lib\search.js
line 89

Was:

     , version: Object.keys(data.versions)[0] || []

My local fix:

     , version: Object.keys(data.versions || {})[0] || []

I'm not set up Git-wise yet, so can't offer any direct contribution yet & can't see the Windows Package anywhere in the Repo...
Update:
The bug isn't present in the current npm version, so I'd guess the Windows Package just needs npm source updating?

@gonium

This comment has been minimized.

Show comment
Hide comment
@gonium

gonium Feb 22, 2014

Confirmed. The proposed patch above worked for me.

gonium commented Feb 22, 2014

Confirmed. The proposed patch above worked for me.

@marcelklehr

This comment has been minimized.

Show comment
Hide comment
@marcelklehr

marcelklehr Feb 26, 2014

Member

npm is up-to-date now.

Member

marcelklehr commented Feb 26, 2014

npm is up-to-date now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment