Minification code has bitrotted, does not minify Javascript anymore #3081

Open
kentonv opened this Issue Nov 16, 2016 · 1 comment

Projects

None yet

2 participants

@kentonv
kentonv commented Nov 16, 2016

Minify.js (https://github.com/ether/etherpad-lite/blob/develop/src/node/utils/Minify.js) invokes uglify-js according to the 1.x API. However, package.json specifies a dependency on the 2.x version of the package, which has a different API.

The problem is easy to miss because Minify.js wraps the whole invocation of uglify-js in a try/catch block that mutes all errors.

https://github.com/ether/etherpad-lite/blob/develop/src/node/utils/Minify.js#L382

@kentonv
kentonv commented Nov 16, 2016

(For Sandstorm I am switching over to minification at build time, so this doesn't affect us, but I thought I'd point it out.)

@Gared Gared added the Bug label Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment