Line attributes not preserved when dragging and dropping line #3118

Open
lpagliari opened this Issue Jan 11, 2017 · 0 comments

Projects

None yet

1 participant

@lpagliari
Contributor
lpagliari commented Jan 11, 2017 edited

bug_dnd-et

How to reproduce:

  • create a pad with 2+ lines
  • set a line attrib on line X
  • set a different line attrib on line Y
  • select the entire line X (including line break)
  • move it to the beginning of line Y

Expected: line X is saved with its original line attribs
What actually happens: line X is saved with line attribs of line Y
Browsers tested: Chrome, Firefox, Safari

I'm already working on the fix for this.

@lpagliari lpagliari self-assigned this Jan 11, 2017
@lpagliari lpagliari added a commit to storytouch/etherpad-lite that referenced this issue Jan 12, 2017
@lpagliari lpagliari [fix] Consider line attribs of plugins when building changesets
When checking the places on text that are identical between content
before and after a changeset, we were considering only the standard
(Etherpad-core) attributes, and not taking into account attributes
created by the plugins. One consequence was that the '*' marker of lines
with line attribs were being kept, even when the new lines have
different line attribs. See #3118 for more details.

Fix #3118.
b2d9f57
@lpagliari lpagliari added a commit to storytouch/etherpad-lite that referenced this issue Jan 12, 2017
@lpagliari lpagliari [chore] Use helper plugin when running tests on Travis
This plugin allows us to test code related to plugins, like testing
issues that only happen when we have plugins using line attribs, for
example (see #3118).
520f257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment