fix for infinite loop on bad changeset #2089

Merged
merged 1 commit into from Mar 13, 2014

Conversation

Projects
None yet
3 participants
Contributor

dmitryuv commented Feb 20, 2014

In case pad state is broken, or bad changeset somehow was submitted to the store, this check is required to avoid infinite loop in the consuming code.

Owner

marcelklehr commented Feb 26, 2014

Will need some testing

marcelklehr referenced this pull request Feb 26, 2014

Merged

Release 1.4.0 #2069

6 of 8 tasks complete
Contributor

dmitryuv commented Feb 28, 2014

@marcelklehr interested in 50% performance improvement for v8 with the changesets library? can make another pull request, but it changes a lot (mainly closures->prototype classes and removal of outdated "optimizations")

Owner

marcelklehr commented Feb 28, 2014

hoh! sounds interesting, will the exposed module API change?

Owner

JohnMcLear commented Feb 28, 2014

Does it break any functionality at all? So far sounds good :) thanks dmitry and in general very pleased you are finding the time and energy to contribute, we appreciate it!

Contributor

dmitryuv commented Feb 28, 2014

@marcelklehr no it don't, API is the same. It's just cosmetic code changes here and there, not "deep refactoring". Everything else is the same. I'll test more with real data and make pull request if everything works fine. Tests are running fine too, but i'm not sure they cover everything.

Owner

JohnMcLear commented Mar 13, 2014

@marcelklehr you happy for this to be merged?

Owner

marcelklehr commented Mar 13, 2014

I barely glanced at this change, it looks like it makes sense. Basic
editing seems to work. It would of course be helpful to have a test case
that fails in the old version and passes with this change.

If it works for dmitry, I guess we can just pull it.

JohnMcLear merged commit cc03f53 into ether:develop Mar 13, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details

dmitryuv deleted the dmitryuv:changesetslib-fixes branch Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment