New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean support for image hook #2497

Merged
merged 5 commits into from Jan 26, 2015
Jump to file or symbol
Failed to load files and symbols.
+35 −1
Diff settings

Always

Just for now

@@ -203,6 +203,29 @@ Things in context:
This hook is called before the content of a node is collected by the usual methods. The cc object can be used to do a bunch of things that modify the content of the pad. See, for example, the heading1 plugin for etherpad original.
## collectContentImage
Called from: src/static/js/contentcollector.js
Things in context:
1. cc - the contentcollector object
2. state - the current state of the change being made
3. tname - the tag name of this node currently being processed
4. style - the style applied to the node (probably CSS)
5. cls - the HTML class string of the node
6. node - the node being modified
This hook is called before the content of an image node is collected by the usual methods. The cc object can be used to do a bunch of things that modify the content of the pad.
Example:
```
exports.collectContentImage = function(name, context){
context.state.lineAttributes.img = context.node.outerHTML;
}
```
## collectContentPost
Called from: src/static/js/contentcollector.js
@@ -458,7 +458,18 @@ function makeContentCollector(collectStyles, abrowser, apool, domInterface, clas
else
{
var tname = (dom.nodeTagName(node) || "").toLowerCase();
if (tname == "br")
if (tname == "img"){
var context = hooks.callAll('collectContentImage', {
cc: cc,
state: state,
tname: tname,
styl: styl,
cls: cls,
node: node
});
}
else if (tname == "br")
{
this.breakLine = true;
var tvalue = dom.nodeAttr(node, 'value');
ProTip! Use n and p to navigate between commits in a pull request.