New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #2566

Merged
merged 49 commits into from Apr 7, 2015

Conversation

Projects
None yet
2 participants
@JohnMcLear
Member

JohnMcLear commented Mar 25, 2015

Merging on 7th of April. Get your complaints in BEFORE then.

Based on the notes at: http://john.primarypad.com/ogf-24-03-15

Designed to resolve: #1803

  • Use Alt Keys to Access Editbar
  • Use Arrow keys to Navigate Editbar
  • Use Alt Keys to access Chat etc.
  • Provide a usable screen reader experience (ARIA specs) (Mostly for visually impaired hombres)
  • Provide fonts suitable for dyslexic users

New tasks as per: https://beta.etherpad.org/p/pvagner%27s_test

  • Make Timeslider Accessible
  • Show users part is not intuitive
  • Additional Keypresses need to be documented in the WIki
  • Hover on buttons is not consistent due to new titles
  • Pressing on Import/Export button seems to lose focus
  • Make Alt C work from anywhere
  • Alt F9 should only work WITH Alt key
  • Make Escape & Alt Keys work from anywhere (not just pad)
  • Ensure left/right arrow keys don't steal focus when on inputs.
  • High Contrast UI - Available through ep_themes
  • Include Open Dyslexic - "Enable Dyslexic(lulz) friendly font" (prolly a pluigin)
  • Fix Good/Bad & Smiley face instead of Good/Bad - Click event with more info including reading score etc. (Blahblahbblahbhlalalalal)
  • Allow left-right arrow keys to cycle from start > end > start again infinitely.
  • Orca and FF 3.14 says the name of the element on focus <-- I run unity which doesn't allow Orca to be easily updated. I might have to resolve this bug once Orca stable lands on Ubuntu unless someone can jump in and resolve that runs Gnome 3 <-- getting a VM to help w/ this -- Orca test is on hold, doing JAWS first.
  • Can't return to pad from Timeslider
  • Use Control Shift 2 instead of Alt Shift A
  • Provide a nice experience for Showing Authors of a line (curent MVP uses Ctrl-Shift-2, try this!)
  • Test with JAWS
  • Write tests for keystrokes -- Is this possible? Looks like it might just be! (see bold.js)
  • Provide in app documentation?
  • Change Font on Timeslider
  • High Contrast on Timeslider (ep_themes)
  • Put some Aria feedback type values on the timeslider so when a revision is moved backwards/forward the screen reader speaks the new revision value and date/time. Also consider putting aria values on the pad contents so the pad contents is spoken to the reader..

TEST at http://beta.etherpad.org
DOCS at https://github.com/ether/etherpad-lite/wiki/Accessibility

@JohnMcLear JohnMcLear changed the title from Accessibility progress to Accessibility Mar 25, 2015

JohnMcLear added some commits Mar 25, 2015

make the pad contents act like an application and not contents, this …
…can probably be togglable but default state should be editable
@JohnMcLear

This comment has been minimized.

Show comment
Hide comment
@JohnMcLear

JohnMcLear Apr 2, 2015

Member

Please note Alt A is now Alt Shift A as per https://bugzilla.mozilla.org/show_bug.cgi?id=1149579

Member

JohnMcLear commented Apr 2, 2015

Please note Alt A is now Alt Shift A as per https://bugzilla.mozilla.org/show_bug.cgi?id=1149579

@JohnMcLear

This comment has been minimized.

Show comment
Hide comment
@JohnMcLear

JohnMcLear Apr 3, 2015

Member

Thinking this for a setting: https://d262ilb51hltx0.cloudfront.net/max/857/0*4QM6Tc6smxr9IWR-.png

On by default

"Keyboard shortcuts" would be a page to a rendered tab of HTML page w/ accessibility controls on built from the Wiki?

Although a user would need to know Alt F9 to get to them so that wouldn't work..

What about a link in the default pad text that points to accessibility? Would only be useful on first pad creation/load and not to pads that have modified contents...

Member

JohnMcLear commented Apr 3, 2015

Thinking this for a setting: https://d262ilb51hltx0.cloudfront.net/max/857/0*4QM6Tc6smxr9IWR-.png

On by default

"Keyboard shortcuts" would be a page to a rendered tab of HTML page w/ accessibility controls on built from the Wiki?

Although a user would need to know Alt F9 to get to them so that wouldn't work..

What about a link in the default pad text that points to accessibility? Would only be useful on first pad creation/load and not to pads that have modified contents...

JohnMcLear added some commits Apr 3, 2015

@JohnMcLear

This comment has been minimized.

Show comment
Hide comment
@JohnMcLear

JohnMcLear Apr 5, 2015

Member

Alt Shift A is now Control Shift 2...

Member

JohnMcLear commented Apr 5, 2015

Alt Shift A is now Control Shift 2...

JohnMcLear added some commits Apr 5, 2015

JohnMcLear added a commit that referenced this pull request Apr 7, 2015

@JohnMcLear JohnMcLear merged commit a534552 into develop Apr 7, 2015

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@lpagliari

This comment has been minimized.

Show comment
Hide comment
@lpagliari

lpagliari Jun 24, 2015

Member

Hey, @JohnMcLear , I know that it's been a while since you've committed this change, but I'm wondering if you had to do this fix to be able to find opendislexyc when minify: true on settings.json.

The reason I'm asking is because on ep_comments_page the font icons are not being correctly displayed when minify is on (I get a 404 when trying to get http://192.168.50.5:9001/font/fontawesome-etherpad.woff, as the file is at http://192.168.50.5:9001/static/font/fontawesome-etherpad.woff), and by doing the same fix for fontawesome-etherpad the error is gone and icons are shown.

As I'm not a CSS expert, I don't know the other possible impacts it could have to make this change. I tested both with minify on and off, and all font icons are correctly displayed (the ones from Etherpad, the ones form plugins), both on the editor and the timeslider.

Is there anything else I should test for?

Member

lpagliari commented on 56ce8e8 Jun 24, 2015

Hey, @JohnMcLear , I know that it's been a while since you've committed this change, but I'm wondering if you had to do this fix to be able to find opendislexyc when minify: true on settings.json.

The reason I'm asking is because on ep_comments_page the font icons are not being correctly displayed when minify is on (I get a 404 when trying to get http://192.168.50.5:9001/font/fontawesome-etherpad.woff, as the file is at http://192.168.50.5:9001/static/font/fontawesome-etherpad.woff), and by doing the same fix for fontawesome-etherpad the error is gone and icons are shown.

As I'm not a CSS expert, I don't know the other possible impacts it could have to make this change. I tested both with minify on and off, and all font icons are correctly displayed (the ones from Etherpad, the ones form plugins), both on the editor and the timeslider.

Is there anything else I should test for?

This comment has been minimized.

Show comment
Hide comment
@JohnMcLear

JohnMcLear Jun 24, 2015

Member

I can probably get a fix in for this today.

Member

JohnMcLear replied Jun 24, 2015

I can probably get a fix in for this today.

This comment has been minimized.

Show comment
Hide comment
@lpagliari

lpagliari Jun 24, 2015

Member

The fix is ready on my machine, I was just wondering if it would have other impacts before submitting the PR.

Member

lpagliari replied Jun 24, 2015

The fix is ready on my machine, I was just wondering if it would have other impacts before submitting the PR.

This comment has been minimized.

Show comment
Hide comment
@JohnMcLear

JohnMcLear Jun 24, 2015

Member

Should be okay, send the PR through and we can try. FWIW I don't know what your fix is...

Member

JohnMcLear replied Jun 24, 2015

Should be okay, send the PR through and we can try. FWIW I don't know what your fix is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment