Accessibility #2566

Merged
merged 49 commits into from Apr 7, 2015

Projects

None yet

2 participants

@JohnMcLear
Member

Merging on 7th of April. Get your complaints in BEFORE then.

Based on the notes at: http://john.primarypad.com/ogf-24-03-15

Designed to resolve: #1803

  • Use Alt Keys to Access Editbar
  • Use Arrow keys to Navigate Editbar
  • Use Alt Keys to access Chat etc.
  • Provide a usable screen reader experience (ARIA specs) (Mostly for visually impaired hombres)
  • Provide fonts suitable for dyslexic users

New tasks as per: https://beta.etherpad.org/p/pvagner%27s_test

  • Make Timeslider Accessible
  • Show users part is not intuitive
  • Additional Keypresses need to be documented in the WIki
  • Hover on buttons is not consistent due to new titles
  • Pressing on Import/Export button seems to lose focus
  • Make Alt C work from anywhere
  • Alt F9 should only work WITH Alt key
  • Make Escape & Alt Keys work from anywhere (not just pad)
  • Ensure left/right arrow keys don't steal focus when on inputs.
  • High Contrast UI - Available through ep_themes
  • Include Open Dyslexic - "Enable Dyslexic(lulz) friendly font" (prolly a pluigin)
  • Fix Good/Bad & Smiley face instead of Good/Bad - Click event with more info including reading score etc. (Blahblahbblahbhlalalalal)
  • Allow left-right arrow keys to cycle from start > end > start again infinitely.
  • Orca and FF 3.14 says the name of the element on focus <-- I run unity which doesn't allow Orca to be easily updated. I might have to resolve this bug once Orca stable lands on Ubuntu unless someone can jump in and resolve that runs Gnome 3 <-- getting a VM to help w/ this -- Orca test is on hold, doing JAWS first.
  • Can't return to pad from Timeslider
  • Use Control Shift 2 instead of Alt Shift A
  • Provide a nice experience for Showing Authors of a line (curent MVP uses Ctrl-Shift-2, try this!)
  • Test with JAWS
  • Write tests for keystrokes -- Is this possible? Looks like it might just be! (see bold.js)
  • Provide in app documentation?
  • Change Font on Timeslider
  • High Contrast on Timeslider (ep_themes)
  • Put some Aria feedback type values on the timeslider so when a revision is moved backwards/forward the screen reader speaks the new revision value and date/time. Also consider putting aria values on the pad contents so the pad contents is spoken to the reader..

TEST at http://beta.etherpad.org
DOCS at https://github.com/ether/etherpad-lite/wiki/Accessibility

JohnMcLear added some commits Mar 25, 2015
@JohnMcLear JohnMcLear first semi working alt f9 functionality 5761e99
@JohnMcLear JohnMcLear different font families for people with dyslexia b72127c
@JohnMcLear JohnMcLear remove console log be73e72
@JohnMcLear JohnMcLear remove console log
c6cac53
@JohnMcLear JohnMcLear changed the title from Accessibility progress to Accessibility Mar 25, 2015
JohnMcLear added some commits Mar 25, 2015
@JohnMcLear JohnMcLear better logic for handling lr arrows
0c902ce
@JohnMcLear JohnMcLear logic to send focus back to pad on Alt F9 when focus on editbar
bc760e9
@JohnMcLear JohnMcLear working f9 logic
e9360b6
@JohnMcLear JohnMcLear whoops
aff802a
@JohnMcLear JohnMcLear support drop down show events
e67ae52
@JohnMcLear JohnMcLear escape to exit editbar
69f0392
@JohnMcLear JohnMcLear make index page accessible for screen readers
4362a42
@JohnMcLear JohnMcLear read for button activity
ec1956b
@JohnMcLear JohnMcLear make the pad contents act like an application and not contents, this …
…can probably be togglable but default state should be editable
1a5ea87
@JohnMcLear JohnMcLear stop listing URL each time focus is placed back on inner iframe
959aa92
@JohnMcLear JohnMcLear more working logic and also pretty nice screen reader experience
7b726cb
@JohnMcLear JohnMcLear fix firefox button styling
6b88c03
@JohnMcLear JohnMcLear more keyboard support while in editbar
548cef7
@JohnMcLear JohnMcLear alt c to focus on chat and gritter and chat both now work with aria
428b547
@JohnMcLear JohnMcLear much better chat focus toggle behavior
19e83d5
@JohnMcLear JohnMcLear fix issue with showControls false not working
f9071ae
@JohnMcLear JohnMcLear dont use nasty settimeouts use a callback instead for focus
a82e692
@JohnMcLear JohnMcLear make Alt C and Alt F9 and Escape work from anywhere
3594898
@JohnMcLear JohnMcLear make buttons i18n friendly and a better experience
ef38bca
@JohnMcLear JohnMcLear fix alt and focus issues
3126d71
@JohnMcLear JohnMcLear make user list a document so it's easy to navigate by screen readers
0f0a6c7
@JohnMcLear JohnMcLear Timeslider accessibility and Bugfixes
73073dc
JohnMcLear added some commits Mar 31, 2015
@JohnMcLear JohnMcLear I came to bring the rain.. Let me get my coat... Fix focus on timesli…
…der import export
24e6e17
@JohnMcLear JohnMcLear MVP of alt A behavior to show author of line
498e7f4
@JohnMcLear JohnMcLear slightly different alt stuff
662216b
@JohnMcLear JohnMcLear i18n for timeslider steppers
37c7c7e
@JohnMcLear JohnMcLear better handling for inputs and left and right arrows
48862da
@JohnMcLear JohnMcLear doh caps
64034ee
@JohnMcLear JohnMcLear expose method for getting a full user list on the client including hi…
…storical data
e9d8c3b
@JohnMcLear JohnMcLear Merge branch 'develop' of github.com:ether/etherpad-lite into editbar…
…-accessibility
0b90da1
@JohnMcLear JohnMcLear fix font type test
733deb6
@JohnMcLear JohnMcLear fix import issue with txt files and abiword #2572
fef746e
@JohnMcLear JohnMcLear referenced this pull request in MozillaFoundation/mofo-lightsaber Apr 1, 2015
Open

Bump Marco Zehe RE Accessibility #30

JohnMcLear added some commits Apr 1, 2015
@JohnMcLear JohnMcLear fix timeslider title issues
f6b4b56
@JohnMcLear JohnMcLear Merge branch 'develop' of github.com:ether/etherpad-lite into editbar…
…-accessibility
ee5833b
@JohnMcLear JohnMcLear change to alt shit and a to show authors 85fc012
@JohnMcLear
Member

Please note Alt A is now Alt Shift A as per https://bugzilla.mozilla.org/show_bug.cgi?id=1149579

JohnMcLear added some commits Apr 2, 2015
@JohnMcLear JohnMcLear Merge branch 'editbar-accessibility' of github.com:ether/etherpad-lit…
…e into editbar-accessibility
139edce
@JohnMcLear JohnMcLear final accessibility for Timeslider hopefully
f79e2c7
@JohnMcLear JohnMcLear temp solution for alt 9 to show editbar label
9090d76
@JohnMcLear
Member

Thinking this for a setting: https://d262ilb51hltx0.cloudfront.net/max/857/0*4QM6Tc6smxr9IWR-.png

On by default

"Keyboard shortcuts" would be a page to a rendered tab of HTML page w/ accessibility controls on built from the Wiki?

Although a user would need to know Alt F9 to get to them so that wouldn't work..

What about a link in the default pad text that points to accessibility? Would only be useful on first pad creation/load and not to pads that have modified contents...

JohnMcLear added some commits Apr 3, 2015
@JohnMcLear JohnMcLear title for chat
c65ddad
@JohnMcLear JohnMcLear fix issue where focus on timeslider wouldnt work
db0bcdd
@JohnMcLear JohnMcLear use ctrl shift 2 instead of alt a
e49bb40
@JohnMcLear JohnMcLear support for open dyslexic font
41bb4ef
@JohnMcLear JohnMcLear hacky fix for opendyslexic
56ce8e8
@JohnMcLear
Member

Alt Shift A is now Control Shift 2...

JohnMcLear added some commits Apr 5, 2015
@JohnMcLear JohnMcLear timeslider settings for fonts
e027083
@JohnMcLear JohnMcLear Merge branch 'develop' of github.com:ether/etherpad-lite into editbar…
…-accessibility
7e99724
@JohnMcLear JohnMcLear merged commit a534552 into develop Apr 7, 2015

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@lpagliari
Contributor

Hey, @JohnMcLear , I know that it's been a while since you've committed this change, but I'm wondering if you had to do this fix to be able to find opendislexyc when minify: true on settings.json.

The reason I'm asking is because on ep_comments_page the font icons are not being correctly displayed when minify is on (I get a 404 when trying to get http://192.168.50.5:9001/font/fontawesome-etherpad.woff, as the file is at http://192.168.50.5:9001/static/font/fontawesome-etherpad.woff), and by doing the same fix for fontawesome-etherpad the error is gone and icons are shown.

As I'm not a CSS expert, I don't know the other possible impacts it could have to make this change. I tested both with minify on and off, and all font icons are correctly displayed (the ones from Etherpad, the ones form plugins), both on the editor and the timeslider.

Is there anything else I should test for?

Member

I can probably get a fix in for this today.

Contributor

The fix is ready on my machine, I was just wondering if it would have other impacts before submitting the PR.

Member

Should be okay, send the PR through and we can try. FWIW I don't know what your fix is...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment