New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line number display when plugin add padding-top (like ep_page_view) #3352

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
3 participants
@ldidry
Contributor

ldidry commented Mar 25, 2018

Line numbering display was broken when using page view since a3765d9.

The first number took the line height plus 100px, due to ep_page_view padding-top CSS rule.

This fixes the problem.

@JohnMcLear JohnMcLear merged commit eb9875e into ether:develop Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@renebrain

This comment has been minimized.

renebrain commented Apr 6, 2018

For us non pluign user it screws the entire line count, so we removed that line locally on our side. I guess there are errors getting thrown so ethepad goes back to default line heights/margins/Paddings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment