This repository has been archived by the owner. It is now read-only.

PATCH: Wrongly nested divs in pad_body2.ejs #293

Closed
erdgeist opened this Issue Sep 8, 2011 · 0 comments

Comments

Projects
None yet
2 participants
@erdgeist

erdgeist commented Sep 8, 2011

The DIV for offline_notification is not closed when it should but only at the end of template.define('modals'…)

This leads to the share box not appearing because it is under "connectionboxinner" in the DOM tree. The patch below fixes this problem

erdgeist

http://pastebin.com/GmCCuUyC

==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8< ==== 8<

diff --git a/etherpad/src/themes/default/templates/pad/pad_body2.ejs b/etherpad/src/themes/default/templates/pad/pad_body2.ejs
index 196b5f4..f65762a 100644
--- a/etherpad/src/themes/default/templates/pad/pad_body2.ejs
+++ b/etherpad/src/themes/default/templates/pad/pad_body2.ejs
@@ -447,6 +447,7 @@ limitations under the License. */ %>
          </div>
          <div id="offline_notification">
            <p>Or just hide this dialog and review document.</p>
+          </div>
          <div id="hide_dialog">
            <button id="hidedialog">Hide</button>
          </div>
@@ -517,7 +518,6 @@ limitations under the License. */ %>
         <div style="clear: both;"></div>
       </div>
     </div>
-  </div>
 <% return ejs_data; }); %>

 <% template.define('pageBottom', function() { var ejs_data=''; %>

@sesam sesam closed this Oct 21, 2011

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.