This repository has been archived by the owner on Jul 9, 2018. It is now read-only.
Debian packaging suggestion: Don't overwrite /etc/etherpad/etherpad.local.properties if it already exists. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most important is to not overwrite a config file that may even be the only place where etherpad's local DB-password is stored. I guess on Debian a fresh etherpad install would never be ready to run right after installation, that you still have to edit the .properties-file? if so, then let's merge this patch immediately :) |
|
+1, sound good |
Pita
added a commit
that referenced
this pull request
May 23, 2011
Debian packaging suggestion: Don't overwrite /etc/etherpad/etherpad.local.properties if it already exists.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch just skips writing a new /etc/etherpad/etherpad.local.properties if it already exists.
This is not an ideal solution, someone with better knowledge about that whole dpkg-thing can probably make this work with an configuration overwrite prompt or something like that.
I still belive that this is better than destroying current config.