Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Process for Core EIP Proposal #19

Closed
timbeiko opened this issue Mar 13, 2019 · 15 comments
Closed

Document Process for Core EIP Proposal #19

timbeiko opened this issue Mar 13, 2019 · 15 comments

Comments

@timbeiko
Copy link
Contributor

In order for the community to know what is required to propose a Core EIP, we should document the process and "non-spec" requirements. Spec requirements can be found in EIP-1.

The process documented should ideally cover everything from "I have an idea to an EIP" to "my EIP is live on mainnet". This includes, non-exhaustively:

  • Proposing an EIP
  • Socializing an EIP / getting community support
  • The technical requirements for an EIP to be implemented (working code, test vectors, etc.)
  • Client or financial support for implementation
  • etc.
@bmann
Copy link
Contributor

bmann commented Mar 15, 2019

Yes, something that is more human readable and is broader than the technical bits and covers CoreDev process would be good.

@timbeiko
Copy link
Contributor Author

Thinking about this more, perhaps a better way to do this is to simply place a PR against https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md? Looking at what is already there, it seems like the socializing part is the least defined, along with the client/financial support.

@bmann
Copy link
Contributor

bmann commented Mar 15, 2019

All of the above ;)

I’d like to keep EIP-1 technically focused — while explaining a bunch more meta.

I had said to EthHub that it might be good content for their site.

We can use this repo and/or a HackMD to start this task. Could also be published as a page on the EIPs website.

@poojaranjan
Copy link
Member

@timbeiko thanks for sharing, will update as we go.

@timbeiko
Copy link
Contributor Author

I've created an outline of what this could look like in HackMD: https://hackmd.io/s/BJIB4Ofu4
A few questions before I go further:

  1. Should we focus this on Core EIPs or any EIPs?
  2. Is there anything that is missing from the process? I tried to model the outline on the EIP-1 format.
  3. How much/little should we reference EIP-1? Should the document assume someone has read + understood EIP-1, or should we assume no-prior knowledge?

@sneg55
Copy link

sneg55 commented Mar 22, 2019

  1. what's the difference between Core EIPs and other EIPs?
  2. I would assume no-prior knowledge

@timbeiko
Copy link
Contributor Author

timbeiko commented Mar 22, 2019

what's the difference between Core EIPs and other EIPs?

"Core" is defined in the EIPS repo as the following:

improvements requiring a consensus fork (e.g. EIP5, EIP101), as well as changes that are not necessarily consensus critical but may be relevant to “core dev” discussions (for example, EIP90, and the miner/node strategy changes 2, 3, and 4 of EIP86).

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md#eip-types

Basically, Core EIPs likely require a hard fork.

@bmann
Copy link
Contributor

bmann commented Mar 22, 2019

For reference to capture other discussions - here’s how README and EIP-1 conflict https://ethereum-magicians.org/t/eth1x-istanbul-prep-meeting/2396/9

@poojaranjan
Copy link
Member

I've created an outline of what this could look like in HackMD: https://hackmd.io/s/BJIB4Ofu4
A few questions before I go further:

  1. Should we focus this on Core EIPs or any EIPs?
  2. Is there anything that is missing from the process? I tried to model the outline on the EIP-1 format.
  3. How much/little should we reference EIP-1? Should the document assume someone has read + understood EIP-1, or should we assume no-prior knowledge?

We may possibly add this in socialization, after introduction of draft EIP and / or before last call

  • Introduce it (or Shout out for last call) on  gitter, reddit, and core dev call (possibly add it in agenda - new EIP / last call EIP )
  • Blog post by the author for background, need and application of the EIP.
  • Reach out to ECH or reviewers for review, when EIP is ready (if applied). ECH may coordinate with reviewers based on the interest / availability.

@timbeiko
Copy link
Contributor Author

Small change to EIP1 proposed here: ethereum/EIPs#1858

@timbeiko
Copy link
Contributor Author

timbeiko commented Apr 3, 2019

Linking this merged PR to EIP-1: https://github.com/ethereum/EIPs/pull/1896/files as well as a relevant EthMagicians thread: https://ethereum-magicians.org/t/definitions-of-governance-layers/3054

@timbeiko
Copy link
Contributor Author

timbeiko commented Apr 9, 2019

My first stab at adding something to eips.ethereum.org to describe the process: ethereum/EIPs#1932

@poojaranjan
Copy link
Member

poojaranjan commented Apr 16, 2019

Formal process of selection of EIPs for hardforks (Meta EIP#) proposed here based on the last discussion in ECH.

@timbeiko
Copy link
Contributor Author

timbeiko commented May 3, 2019

Closed my original PR in favor of ethereum/EIPs#1991

@timbeiko
Copy link
Contributor Author

And ethereum/EIPs#1991 has just been merged 🎉! closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants