Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC endpoints #12

Closed
ligi opened this issue Jan 15, 2019 · 10 comments
Closed

Add RPC endpoints #12

ligi opened this issue Jan 15, 2019 · 10 comments
Labels
enhancement New feature or request

Comments

@ligi
Copy link
Member

ligi commented Jan 15, 2019

wonder if we should add a list of RPC endpoints (can also be an empty list - so the field is optional) for the chains.
Inspired by #10 (comment)

This would also allow a ci-script to make checks for the chain_id (also inspired by the very same PR)

Disadvantage might be that it is widening the scope too much - what does the rest of the team think?

@ligi ligi added the question Further information is requested label Jan 15, 2019
@bmann
Copy link
Contributor

bmann commented Jan 15, 2019

Chatted to @ligi about this. Let’s add valuable per chain data if we have data for a number of chains. Let’s learn what’s most useful and go from there.

@ligi ligi added enhancement New feature or request and removed question Further information is requested labels Jan 31, 2019
@ligi
Copy link
Member Author

ligi commented Jan 31, 2019

Moving from question to enhancement as I see rough consensus here

@saurik
Copy link
Contributor

saurik commented Sep 20, 2020

Can this list also include ws/wss endpoints in addition to http/https endpoints, or would you want that in a different key?

@ligi
Copy link
Member Author

ligi commented Sep 20, 2020

Good question. I would say yes as it seems to be the most clean solution. But I am not 100% sure if all consuming parties can deal with it (meaning e.g. ignore these entries if wss is not supported). I will try to reach out to some people. Where do you want to add them currently?

@saurik
Copy link
Contributor

saurik commented Sep 20, 2020

@ligi By "where" do you mean "for which chains" or "where in the schema"? I know of public websocket endpoints for at least POA, xDai, and Binance Smart Chain; and, since Infura API keys are allowed as parameters, Ethereum. (As for the schema, I personally felt they should go in the same list as the http endpoints, and that is where I was putting them in the little database of chains I was momentarily putting together yesterday, before my research led me to this shared resource; but I don't actually "care", which is why I asked where you all felt they should go ;P.)

@ligi
Copy link
Member Author

ligi commented Sep 21, 2020

@saurik great! yea with "where" I mean which chains.
I think just go ahead with it. Thought about it a bit more and there was never actually a guarantee that these are only http(s) addresses. Was just the case by chance until now. IMHO it is totally valid to also add wss:// URLs

@nicexe
Copy link

nicexe commented Oct 28, 2020

I'm not sure what the purpose of adding RPC endpoints serves.
If you connect a node to a network, you have your own RPC endpoint at http://127.0.0.1:8545 or ws://127.0.0.1:8546
Maybe there is something that I'm not getting here.

@ligi
Copy link
Member Author

ligi commented Oct 29, 2020

this is about public endpoints. Not always you have access to a local endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@saurik @ligi @bmann @nicexe and others