New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Public RPC Endpoints #20

Merged
merged 4 commits into from Feb 9, 2019

Conversation

Projects
None yet
3 participants
@pedrouid
Copy link
Collaborator

pedrouid commented Feb 8, 2019

Fix #12

@ligi
Copy link
Member

ligi left a comment

Thanks. But I think it would be better to have a list of endpoints rather than one. This list can be empty.

@pedrouid

This comment has been minimized.

Copy link
Collaborator Author

pedrouid commented Feb 8, 2019

Done, should we change the name then?

@ligi

This comment has been minimized.

Copy link
Member

ligi commented Feb 8, 2019

yea - perhaps just "rpc": [...]

@pedrouid

This comment has been minimized.

Copy link
Collaborator Author

pedrouid commented Feb 8, 2019

Done! Good to merge

@ligi
Copy link
Member

ligi left a comment

I think we can just have empty lists - so [""] -> []

@ligi

ligi approved these changes Feb 9, 2019

@ligi ligi merged commit 1463d58 into master Feb 9, 2019

1 check passed

kontinuum/checkout checkout done
Details
@ligi

This comment has been minimized.

Copy link
Member

ligi commented Feb 9, 2019

👍

@bmann

This comment has been minimized.

Copy link
Collaborator

bmann commented Feb 9, 2019

Ideally all data fields are displayed on at least the /chains page which has enough room to include all information about the chain and can be human browseable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment