Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up command line arguments processing #1160
requested review from
May 26, 2018
I was thinking a single main.cpp file. MinerAux.h is only included by main.cpp so it is not the typical header file. It contains mostly executable code and no common (shared) variables. It is strictly for main.cpp's use, so why not just include it as part of main.cpp instead of #including it as a separate file?
Mine was only a suggestion due to personal habit ... wether there is a class (MinerCLI is) I prefer to have definition into .h and executable code in .cpp
Definitely, move code from MinerAux to main.cpp. The MinerAux was shared between eth/main and ethminer/main long time ago.
@jean-m-cyr could you please add in help text the meanings for stratumx+tcp modes ?