New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical amendment to GetWorkClient #1215

Merged
merged 2 commits into from Jun 5, 2018

Conversation

Projects
None yet
2 participants
@AndreaLanfranchi
Collaborator

AndreaLanfranchi commented Jun 4, 2018

Addresses #1213

  • Solution submit is immediate upon arrival and is no influenced by --farm-recheck value
  • Submission of hashrate is conditional
  • Renamed m_report_stratum_hashrate to m_report_hashrate as it's valid for both modes

Now even sligtly higher --farm-recheck values may be applied to mitigate overhead.

@AndreaLanfranchi AndreaLanfranchi requested review from chfast, smurfy and jean-m-cyr Jun 4, 2018

@AndreaLanfranchi AndreaLanfranchi changed the title from Minimal amendment to GetWorkClient to Critical amendment to GetWorkClient Jun 4, 2018

Show outdated Hide outdated libpoolprotocols/getwork/EthGetworkClient.h
// Store the solution in temp var. Will be handled in workLoop
m_solutionToSubmit = solution;
// Immediately send found solution without wait for loop
if (m_connected || m_justConnected) {

This comment has been minimized.

@chfast

chfast Jun 4, 2018

Contributor

What is the m_justConnected flag for?

@chfast

chfast Jun 4, 2018

Contributor

What is the m_justConnected flag for?

This comment has been minimized.

@AndreaLanfranchi

AndreaLanfranchi Jun 5, 2018

Collaborator

Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.

@AndreaLanfranchi

AndreaLanfranchi Jun 5, 2018

Collaborator

Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.

// Store the solution in temp var. Will be handled in workLoop
m_solutionToSubmit = solution;
// Immediately send found solution without wait for loop
if (m_connected || m_justConnected) {

This comment has been minimized.

@chfast

chfast Jun 4, 2018

Contributor

What is the m_justConnected flag for?

@chfast

chfast Jun 4, 2018

Contributor

What is the m_justConnected flag for?

This comment has been minimized.

@AndreaLanfranchi

AndreaLanfranchi Jun 5, 2018

Collaborator

Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.

@AndreaLanfranchi

AndreaLanfranchi Jun 5, 2018

Collaborator

Really do not know. I only replicated what i believe is the "connected" condition imposed in workloop. I did not write this class.

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Jun 4, 2018

Contributor

Also add CHANGELOG entry.

Contributor

chfast commented Jun 4, 2018

Also add CHANGELOG entry.

AndreaLanfranchi added some commits Jun 4, 2018

Minimal amendment to GetWorkClient
Addresses #1213

- Solution submit is immediate upon arrival and is no influenced by
--farm-recheck value
- Submission of hashrate is conditional
- Renamed m_report_stratum_hashrate to m_report_hashrate as it's valid
for both modes

Now even sligtly higher --farm-recheck values may be applied to mitigate
overhead.
@chfast

chfast approved these changes Jun 5, 2018

@AndreaLanfranchi AndreaLanfranchi merged commit ceb9813 into master Jun 5, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AndreaLanfranchi AndreaLanfranchi deleted the getwork branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment