Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change bedrock link checker to run nightly instead of on every PR #5597

Merged
merged 1 commit into from
May 4, 2023

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented May 4, 2023

Description

Moves the bedrock markdown link check to a daily scheduled job rather than being run on every PR. This should make it less likely that we'll get blocked for spamming sites with suspicious looking requests and will at least reduce the noise on PRs if we do.

Additional context

Slack notification of failures is going to the new notify-link-check channel.

Metadata

@ajsutton ajsutton requested a review from a team as a code owner May 4, 2023 02:04
@ajsutton ajsutton requested a review from felipe-op May 4, 2023 02:04
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

⚠️ No Changeset found

Latest commit: 55b49f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 55b49f8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64542b92ee69970008de2c67

Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to remove it from the main workflow?

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label May 4, 2023
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

Hey @ajsutton, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label May 4, 2023
@mergify mergify bot removed the conflict label May 4, 2023
@OptimismBot OptimismBot merged commit ec104d3 into develop May 4, 2023
@OptimismBot OptimismBot deleted the aj/periodic-link-check branch May 4, 2023 22:19
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants