-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Change bedrock link checker to run nightly instead of on every PR #5597
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to remove it from the main
workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR has been added to the merge queue, and will be merged soon. |
Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review. |
Hey @ajsutton, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
7947a9a
to
55b49f8
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Moves the bedrock markdown link check to a daily scheduled job rather than being run on every PR. This should make it less likely that we'll get blocked for spamming sites with suspicious looking requests and will at least reduce the noise on PRs if we do.
Additional context
Slack notification of failures is going to the new
notify-link-check
channel.Metadata