Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-export json in typescript deploy-configs #5607

Merged
merged 2 commits into from
May 4, 2023
Merged

fix: Re-export json in typescript deploy-configs #5607

merged 2 commits into from
May 4, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 4, 2023 •
edited
Loading

Description

Updates the mainnet.ts deploy-config to re-export the object defined in mainnet.json to de-duplicate values and re-define values inline.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7bc1dc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell refcell requested review from tynes and maurelian May 4, 2023 17:14
@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 7bc1dc5
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6453f9947e8d700008aadab8

@tynes
Copy link
Contributor

tynes commented May 4, 2023

This can still result in a diff between the two

@refcell refcell marked this pull request as ready for review May 4, 2023 17:28
@refcell refcell requested a review from a team as a code owner May 4, 2023 17:28
maurelian
maurelian approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment nit suggestions

packages/contracts-bedrock/deploy-config/mainnet.ts Outdated Show resolved Hide resolved
packages/contracts-bedrock/deploy-config/mainnet.ts Outdated Show resolved Hide resolved
packages/contracts-bedrock/deploy-config/mainnet.ts Outdated Show resolved Hide resolved
@refcell refcell self-assigned this May 4, 2023
@refcell
Updates the mainnet typescript deploy config to re-export json
c848c41 
to de-duplicate hard-coded values, allow for backwards typescript
compatibility, and maintain the use of comments.
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 809af23 into develop May 4, 2023
@OptimismBot OptimismBot deleted the refcell/reexport/json branch May 4, 2023 18:45
@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@maurelian maurelian maurelian approved these changes

@tynes tynes Awaiting requested review from tynes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refcell @tynes @clabby @maurelian @OptimismBot