Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-e2e: wait for observed seq reorg in TestMissingBatchE2E #5614

Merged
merged 2 commits into from
May 4, 2023
Merged

op-e2e: wait for observed seq reorg in TestMissingBatchE2E #5614

merged 2 commits into from
May 4, 2023

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented May 4, 2023

Description

Don't rely on timing for the L2 sequencer reorg in TestMissingBatchE2E.

Metadata

@Inphi Inphi requested a review from a team as a code owner May 4, 2023 20:58
@Inphi Inphi requested a review from trianglesphere May 4, 2023 20:58
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 75a2d57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 75a2d57
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64541f327bfdb4000824613f

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

trianglesphere
trianglesphere approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@OptimismBot OptimismBot merged commit d04876f into develop May 4, 2023
@OptimismBot OptimismBot deleted the inphi/missing-batch branch May 4, 2023 21:25
@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Inphi @ajsutton @trianglesphere @OptimismBot