Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base Goerli chain ID and addresses to JS SDK #5623

Merged
merged 4 commits into from
May 8, 2023

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented May 5, 2023

Description

Adds the Base Goerli chain ID (84531) to the Javascript SDK. Also adds the Base Goerli contract addresses (mainnet is not yet deployed).

Tests

None added, just adding constants.

Additional context

We are attempting to get fault-detector up and running, and seeing:

Error: cannot get contract AddressManager for unknown L2 chain ID 84531, you must provide an address

TODOs

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

⚠️ No Changeset found

Latest commit: 7b62702

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 7b62702
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6459030e88743e0008130deb

@mergify mergify bot added the sdk label May 5, 2023
@mergify mergify bot requested a review from roninjin10 May 5, 2023 13:15
@mdehoog mdehoog changed the title Add Base chain IDs and addresses to JS SDK Add Base Goerli chain ID and addresses to JS SDK May 5, 2023
roninjin10
roninjin10 previously approved these changes May 5, 2023
@mdehoog mdehoog marked this pull request as ready for review May 8, 2023 13:52
@mdehoog mdehoog requested a review from a team as a code owner May 8, 2023 13:52
@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 73e62b9 into ethereum-optimism:develop May 8, 2023
@mergify mergify bot removed the on-merge-train label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants