Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault-detector: contract address override for custom op-chains #5692

Merged
merged 3 commits into from
May 12, 2023

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented May 11, 2023

Description

Custom deployments of the op stack generates new L1 optimism contracts. In order for the fault detector to work, the needed contract addresses need to be threaded through to the fault detector.

via the CrossChainMessenger class, the fault detector interacts the (OptimismPortal, L2OutputOracle, & SmartCommitmentChain) contracts depending on if the op-chain is bedrock or legacy. We can supply arguments to explicitly set these addresses.

Note: The L2OutputOracle contract can be fetched from the OptimismPortal contract. For this reason, we omit needing to specify the L2OutputOracle contract.

Tests
No unit tests as core logic in the fault detector is untouched. This just needs to be tested against a custom op chain.

Addresses DX-7

@hamdiallam hamdiallam requested a review from a team as a code owner May 11, 2023 21:54
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

⚠️ No Changeset found

Latest commit: d088ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d088ebd
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645e5dc2cf86e7000805336a

@hamdiallam hamdiallam changed the title [fault-detector] Specify necessary contracts for custom op-chains fault-detector: contract address override for custom op-chains May 12, 2023
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #5692 (d088ebd) into develop (b2ffb0f) will decrease coverage by 2.93%.
The diff coverage is 3.12%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5692      +/-   ##
===========================================
- Coverage    41.94%   39.01%   -2.93%     
===========================================
  Files          444      291     -153     
  Lines        29032    24642    -4390     
  Branches       861       24     -837     
===========================================
- Hits         12178     9615    -2563     
+ Misses       15910    14131    -1779     
+ Partials       944      896      -48     
Flag Coverage Δ
bedrock-go-tests 39.10% <ø> (-0.05%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests 28.90% <3.12%> (-4.98%) ⬇️
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fault-detector/src/service.ts 5.88% <3.12%> (-1.50%) ⬇️

... and 154 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 509911e into develop May 12, 2023
@OptimismBot OptimismBot deleted the hamdi/fault.detector branch May 12, 2023 15:54
@mergify mergify bot removed the on-merge-train label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants