-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fault-detector: contract address override for custom op-chains #5692
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5692 +/- ##
===========================================
- Coverage 41.94% 39.01% -2.93%
===========================================
Files 444 291 -153
Lines 29032 24642 -4390
Branches 861 24 -837
===========================================
- Hits 12178 9615 -2563
+ Misses 15910 14131 -1779
+ Partials 944 896 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Custom deployments of the op stack generates new L1 optimism contracts. In order for the fault detector to work, the needed contract addresses need to be threaded through to the fault detector.
via the
CrossChainMessenger
class, the fault detector interacts the (OptimismPortal, L2OutputOracle, & SmartCommitmentChain) contracts depending on if the op-chain is bedrock or legacy. We can supply arguments to explicitly set these addresses.Tests
No unit tests as core logic in the fault detector is untouched. This just needs to be tested against a custom op chain.
Addresses DX-7