Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devnet: unify tooling for how to bring up devnet #6010

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 13, 2023

Description

The bash script is removed in favor of unifying on the python code. In the future we should only have 1 way to bring up the devnet because it is difficult to maintain 2 different ways. It adds additional CI runs plus the need to add functionality to 2 different things when contracts are added to the system.

The bash script is removed in favor of unifying on the python
code. In the future we should only have 1 way to bring up the devnet
because it is difficult to maintain 2 different ways. It adds
additional CI runs plus the need to add functionality to 2 different
things when contracts are added to the system.
@tynes tynes requested a review from a team as a code owner June 13, 2023 23:32
@tynes tynes requested a review from protolambda June 13, 2023 23:32
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: d48f327

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d48f327
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64890b427284160008446dbb

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #6010 (d3380c8) into develop (c3cff50) will increase coverage by 28.91%.
The diff coverage is n/a.

❗ Current head d3380c8 differs from pull request most recent head d48f327. Consider uploading reports for the commit d48f327 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #6010       +/-   ##
============================================
+ Coverage    15.48%   44.40%   +28.91%     
============================================
  Files            8      299      +291     
  Lines         1485    22986    +21501     
============================================
+ Hits           230    10206     +9976     
- Misses        1233    11825    +10592     
- Partials        22      955      +933     
Flag Coverage Δ
bedrock-go-tests 44.40% <ø> (+28.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 292 files with indirect coverage changes

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was able to spin up the devnet locally with both pre-deploy and deploy modes fine. We do still have two quite divergent paths to spin up the devnet since nearly all the python code is split to different methods depending on the deployment type, but it absolutely makes sense to have them both in python at least. Would have saved me a lot of confusion when I was first understanding how the devnet gets spun up.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR has been added to the merge queue, and will be merged soon.

@tynes
Copy link
Contributor Author

tynes commented Jun 14, 2023

We should eliminate one of the paths and imo it should be the contracts in genesis path, maintaining the L1 portion is not ideal. The same code that deploys to networks should be used for integration testing

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit e33d000 into develop Jun 14, 2023
@OptimismBot OptimismBot deleted the cleanup/devnet branch June 14, 2023 00:38
@mergify mergify bot removed the on-merge-train label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants