-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devnet: unify tooling for how to bring up devnet #6010
Conversation
The bash script is removed in favor of unifying on the python code. In the future we should only have 1 way to bring up the devnet because it is difficult to maintain 2 different ways. It adds additional CI runs plus the need to add functionality to 2 different things when contracts are added to the system.
|
✅ Deploy Preview for opstack-docs canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6010 +/- ##
============================================
+ Coverage 15.48% 44.40% +28.91%
============================================
Files 8 299 +291
Lines 1485 22986 +21501
============================================
+ Hits 230 10206 +9976
- Misses 1233 11825 +10592
- Partials 22 955 +933
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Was able to spin up the devnet locally with both pre-deploy and deploy modes fine. We do still have two quite divergent paths to spin up the devnet since nearly all the python code is split to different methods depending on the deployment type, but it absolutely makes sense to have them both in python at least. Would have saved me a lot of confusion when I was first understanding how the devnet gets spun up.
This PR has been added to the merge queue, and will be merged soon. |
We should eliminate one of the paths and imo it should be the contracts in genesis path, maintaining the L1 portion is not ideal. The same code that deploys to networks should be used for integration testing |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
The bash script is removed in favor of unifying on the python code. In the future we should only have 1 way to bring up the devnet because it is difficult to maintain 2 different ways. It adds additional CI runs plus the need to add functionality to 2 different things when contracts are added to the system.