Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-service: Log a warning when an RPC request has to be retried #6070

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

ajsutton
Copy link
Contributor

Description

When the retrying RPC client has to retry a request, log a warning so the user knows that something didn't work. Will fix op-program goerli-verify job timing out because it went 10 minutes with no output and provide useful information to the user when things aren't working correctly.

@ajsutton ajsutton requested a review from a team as a code owner June 20, 2023 06:49
@ajsutton ajsutton requested a review from mslipper June 20, 2023 06:49
@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: e46a976

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit e46a976
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64914c3263108d0007b2ee4b

@ajsutton ajsutton force-pushed the aj/log-failures-when-retrying branch from 8b0711f to e46a976 Compare June 20, 2023 06:50
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6070 (e46a976) into develop (e8cdf4e) will increase coverage by 0.16%.
The diff coverage is 92.30%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6070      +/-   ##
===========================================
+ Coverage    44.53%   44.70%   +0.16%     
===========================================
  Files          412      298     -114     
  Lines        26263    22949    -3314     
  Branches       684        0     -684     
===========================================
- Hits         11697    10259    -1438     
+ Misses       13577    11742    -1835     
+ Partials       989      948      -41     
Flag Coverage Δ
bedrock-go-tests 44.70% <92.30%> (+0.01%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-program/host/host.go 32.27% <0.00%> (ø)
op-service/client/retry.go 100.00% <100.00%> (ø)

... and 115 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 0c5bf86 into develop Jun 20, 2023
@OptimismBot OptimismBot deleted the aj/log-failures-when-retrying branch June 20, 2023 10:21
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants