Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ERC-1328 - WalletConnect Standard URI Format #1328
A standard way of creating WalletConnect URIs for establishing connections between wallets and dapps
Sesion data in QR codes for initiating a connection between a wallet and dapp using the WalletConnect standard require a standardized URI format for effictively parsing the intenet. This ERC is expandable between versions of the standard and also mobile-to-mobile deep links.
Function call URIs follow the ERC-831 URI format, with the following parameters:
Required parameters are dependent on the WalletConnect standard version which currently is specified to only include mobile-to-desktop connection sessions which only require
The need for this ERC stems from the discussion to move away from JSON format used in current beta version of the WalletConnect standard which makes for very inneficient parsing of the intent of the QR code, making it easier to create better QR code parsers APIs for Wallets to implement for other compatible EIPs using the ERC-831 URI format for Ethereum.
Copyright and related rights waived via CC0.
Great! Some minor nit-picks:
I think TYPE should be removed or defined. I would vote for removing it
Btw: It is better to directly start your EIP as a PR - so one can directly write comments like the above on the corresponding line. Also You do not have this waste and overhead of having issue+pr.
I would leave out:
and properly add this when a new version is created. Otherwise this opens it up for getting really messy- people will just start using their custom solutions under the banner of "Optional parameters" and we will loose interoperability and open the door for bugs from this corner.
Also I think we should define the length of symKey
I would replace dapp with application ;-) - you know the context - just for context for others: https://twitter.com/mr_ligi/status/1029682384965316608
Perhaps also this link should be added for context and discussion https://ethereum-magicians.org/t/wallet-connect-eip/850
Other than that - great! Let's finalize and implement - I Think I can have WallETH compatible to this today ,-)