Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 1775 - App Keys, application specific wallet accounts #1775

Merged
merged 92 commits into from May 5, 2019

Conversation

Projects
None yet
4 participants
@Bunjin
Copy link
Contributor

commented Feb 25, 2019

EIP ERC 1775: App Keys, application specific wallet accounts

Abstract:

In a wallet, an user often holds most of her funds in her main accounts. These accounts require a significant level of security and should not be delegated in any way, this significantly impacts the design of cryptographic applications if a user has to manually confirm every action. Also often an user uses the same accounts across apps, which is a privacy and potentially also a security issue.

We introduce here a new account type, app keys, which permits signing delegation and accounts isolation across applications for privacy and security.

In this EIP, we provide a proposal how to uniquely identify and authenticate each application, how to derive the accounts along an Hierachical Deterministic (HD) path restricted for the domain and we finally define an API for applications to derive and use these app keys. This ERC aims at finding a standard that will fit the needs of wallets and application developers while also allowing app keys to be used across wallets and yield the same accounts for the user for each application.

Discussion:

Eth Magicians post:
https://ethereum-magicians.org/t/eip-erc-app-keys-application-specific-wallet-accounts/2742

@Bunjin Bunjin changed the title EIP ERC: App Keys, application specific wallet accounts EIP 1775 - App Keys, application specific wallet accounts Mar 11, 2019

@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Hi,

What's the next step to get this EIP merged as a draft?

Also something is causing the CI test to fail but not sure what and it doesn't seem related to my file.

Warning: EIPS/eip-1066.md 	 undefined method `version=' for #<EipValidator::Validator:0x00000002156d30>
Warning: EIPS/eip-158.md 	 undefined method `superseded_by=' for #<EipValidator::Validator:0x00000002fc5290>
bundler: failed to load command: eip_validator (/home/travis/build/ethereum/EIPs/vendor/bundle/ruby/2.2.0/bin/eip_validator)
Psych::SyntaxError: (<unknown>): mapping values are not allowed in this context at line 3 column 16
@nicksavers

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

@Bunjin The requires and replaces fields can only accept numbers of merged EIPs.
Also an EIP can't and doesn't require a BIP. Mentioning them in the proposal and having links to these under references is enough.

Bunjin added some commits Mar 17, 2019

@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Thanks a lot @nicksavers but I've just tried removing the BIPs, changing the EIP format, removing the the requires and replaces fields, adding them blank and none of these allowed the build to complete.

@nicksavers

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2019

@Bunjin If the ERC requires the other ERC's include them as only numbers. If this ERC doesn't depend on or replace any previous ERC, then remove the fields.

Bunjin added some commits Mar 18, 2019

@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@nicksavers thanks again, however I think I did what you recommend but unfortunately it's still not passing the CI test.

@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@nicksavers problem solved :) It wasn't the requires and replaces fields (although I probably would have had trouble there too). It was the inclusion of a ":" (semi colon) in the title.

Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
Show resolved Hide resolved EIPS/eip-1775.md Outdated
@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Thanks a lot for the reviews @Arachnid and @nicksavers !

I've updated the file following your recommendations and answered a few comments that are still to be discussed.

Bunjin added some commits Apr 1, 2019

@Bunjin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

@nicksavers @Arachnid All comments from review have been addressed and I hope resolved sufficiently well.

Please let me know if we can proceed with the merge.

@nicksavers nicksavers merged commit b922d59 into ethereum:master May 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

drortirosh added a commit to drortirosh/EIPs that referenced this pull request Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.