Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated eip-1679 to contain eip-1108 #1988

Merged
merged 2 commits into from May 9, 2019

Conversation

Projects
None yet
4 participants
@zac-williamson
Copy link
Contributor

commented May 3, 2019

This is a PR to add eip-1108 to the list of proposed EIPs for Istanbul

@eip-automerger

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1679 requires approval from one of (@5chdn, @axic)
@@ -34,6 +34,8 @@ This meta-EIP specifies the changes included in the Ethereum hardfork named Ista
[pending audit](https://medium.com/ethereum-cat-herders/progpow-audit-goals-expectations-75bb902a1f01),
above and beyond standard security considerations, that should be evaluated
prior to inclusion.
- [EIP-1108](https://eips.ethereum.org/EIPS/eip-1108): Reduce alt_bn128 precompile gas costs
- There is currently an outstanding [pull request](https://github.com/ethereum/EIPs/pull/1987) that updates the gas costs to the latest benchmarks

This comment has been minimized.

Copy link
@axic

axic May 3, 2019

Member

I'd prefer we merge #1987 first, remove this comment and merge this to avoid the extra PRs needed to remove this line.

This comment has been minimized.

Copy link
@Shadowfiend

Shadowfiend May 8, 2019

Contributor

Just merged that guy, so it looks like @zac-williamson you just need to drop the note on line 38 and we're maybe good to go here?

This comment has been minimized.

Copy link
@axic

axic May 8, 2019

Member

@zac-williamson can you please do that? I'd like to merge this.

@zac-williamson

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Heya! Sorry for the slow response, I've removed the superfluous line

@axic

axic approved these changes May 9, 2019

@eip-automerger eip-automerger merged commit a808619 into ethereum:master May 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.