Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft EIP: BLS12-381 Keystore #2335

Merged
merged 8 commits into from Dec 2, 2019
Merged

Draft EIP: BLS12-381 Keystore #2335

merged 8 commits into from Dec 2, 2019

Conversation

CarlBeek
Copy link
Contributor

@CarlBeek CarlBeek commented Oct 31, 2019

This is the proposed standard for BLS12-381 Keystores for use within Eth2 as well as by the larger blockchain industry. It has existed in its own repo for a while now, but this is a better place to enshrine it as a standard for now.

EIPS/eip-draft_bls_keystore.md Outdated Show resolved Hide resolved
@axic axic added the type: ERC label Nov 1, 2019
@mpetrunic
Copy link

@mpetrunic mpetrunic commented Nov 25, 2019

Implementation of EIP in typescript: https://github.com/nodefactoryio/bls-keystore

Adds discussions-to

Fix typos

Swap p & r scrypt params

Update EIP name

Actually update the secret

Adds `path` to 1st test

Adds PubKey

Reduce path to uint32

Update links
@mcdee
Copy link
Contributor

@mcdee mcdee commented Nov 25, 2019

If implementations is a thing here is one in go: https://github.com/wealdtech/go-eth2-wallet-encryptor-keystorev4/

@axic
Copy link
Member

@axic axic commented Nov 26, 2019

@CarlBeek can you confirm you're happy with my tiny changes?

axic and others added 4 commits Nov 26, 2019
…tore

* 'bls_keystore' of github.com:CarlBeek/EIPs: (47 commits)
  fix link to heading
  Fix spelling
  Fix email address
  Draft EIP: BLS12-381 Deterministic Account Hierarchy (ethereum#2334)
  Fix some URLs and require 2333 too
  Add name to metadata title (ethereum#2370)
  Draft: BLS12-381 Key Generation (ethereum#2333)
  Automatically merged updates to draft EIP(s)  (ethereum#2397)
  Hard fork proposal to address the Ice age (ethereum#2387)
  Automatically merged updates to draft EIP(s) 1767 (ethereum#2262)
  EIP-2021: Payoutable Token (ethereum#2021)
  EIP-2009: Compliance Service (ethereum#2009)
  EIP-2019: Fundable Token (ethereum#2019)
  Use solidity/javascript highlighting in various EIPs (ethereum#2372)
  EIP-2018: Clearable Token (ethereum#2018)
  EIP-1996: Holdable token (ethereum#1996)
  Fix the username of @pizza-r0b in EIP-2309 (ethereum#2389)
  Clarify that empty accounts also return 0 in EIP-1052 (ethereum#2388)
  dType Functions Extension - Decentralized Type System for EVM (ethereum#2267)
  Fix spelling of GitHub [R4R] (ethereum#2369)
  ...
@CarlBeek
Copy link
Contributor Author

@CarlBeek CarlBeek commented Nov 26, 2019

@CarlBeek can you confirm you're happy with my tiny changes?

@axic I am indeed, thank you!

Can I ask you to hold off just a little while longer on the merge though. I'm having an offline discussion which may have ramifications here.

@axic
Copy link
Member

@axic axic commented Dec 2, 2019

@CarlBeek did you progress with the discussion?

@CarlBeek
Copy link
Contributor Author

@CarlBeek CarlBeek commented Dec 2, 2019

@axic, they have concluded. Thank you for waiting. Please merge.

@axic axic merged commit 401b3ca into ethereum:master Dec 2, 2019
1 check passed
@axic
Copy link
Member

@axic axic commented Dec 2, 2019

Actually it seems the rendering of the tables is wrong: https://eips.ethereum.org/EIPS/eip-2335

@paulmillr
Copy link
Contributor

@paulmillr paulmillr commented Dec 9, 2019

Hey folks -- why isn't this using aes-gcm256?

@axic
Copy link
Member

@axic axic commented Dec 9, 2019

@paulmillr please leave this question on the discussion URL: #2339

@axic
Copy link
Member

@axic axic commented Dec 9, 2019

Actually it seems the rendering of the tables is wrong: https://eips.ethereum.org/EIPS/eip-2335

@CarlBeek can you fix this?

@axic
Copy link
Member

@axic axic commented May 13, 2020

Actually it seems the rendering of the tables is wrong: https://eips.ethereum.org/EIPS/eip-2335

@CarlBeek this still seems to be a problem.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this issue Nov 7, 2020
Arachnid pushed a commit to Arachnid/EIPs that referenced this issue Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants