EIP-2494 Baby Jubjub Elliptic Curve #2494

bellesmarta · 2020-01-29T08:39:57Z

This pull request stands for EIP-2494 proposing Baby Jubjub, a twisted Edwards elliptic curve designed to work inside zk-SNARK circuits in Ethereum. Contribute and follow the discussion thread at https://ethereum-magicians.org/t/eip-2494-baby-jubjub-elliptic-curve/3968.

axic · 2020-01-29T10:01:18Z

Discussion thread in #2493.

eip-draft_babyjubjub.md

axic · 2020-01-29T10:16:09Z

eip-draft_babyjubjub.md

+eip:      2494
+title:    Baby Jubjub Elliptic Curve
+authors:  Barry WhiteHat (@barryWhiteHat), Marta Bellés (@bellesmarta), Jordi Baylina (@jbaylina)
+discussions-to: https://github.com/ethereum/EIPs/pull/2494


This should link to https://github.com/ethereum/EIPs/issues/2493

Issue #2493 is closed. The discussion thread is moved to https://ethereum-magicians.org/t/eip-2494-baby-jubjub-elliptic-curve/3968.

FYI: At the time I wrote the comment, the issue was still open.

I opened and closed it now, could you check if it is okay now?

Hm? I wrote the comment at 10:16 GMT and the issue was first closed 10:45 GMT. I've only mentioned it for the record.

jbaylina · 2020-01-29T10:51:30Z

axic said:

This seems to be a specification of the new curve and not a direct integration into Ethereum. Because of that I would think perhaps some other mediums are better for publication if wider adoption is encouraged.

Perhaps IETF RFCs? A bunch of curves were specified as RFCs.

Right now, this curve is widelly used in the Ethereum space, so I think it make sense to have a standard here.

I don't think it's incompatible to start a RFC process, but this will require time and effort. So I think it's worthy to have a standarize as an ERC.

This is the base of other upcoming standards like EdDSA based on this curve, Baby Jub derivation key from an Ethereum Key, Signature aggregation, etc.

Updated discussions-to link.

Added Go implementation of the curve.

paulmillr · 2020-02-03T04:53:50Z

Why isn't this bls12-381?

jbaylina · 2020-02-03T05:00:20Z

Currently, the only cure that is supported in Ethereum precompiled smart contract is BN-128.
For BLS12-381, you can check the ZCash JubJub curve.

paulmillr · 2020-02-03T05:35:21Z

Understood. I wish there was an effort for precompiled bls12-381, since eth2 is using it. Interop is great.

eip-draft_babyjubjub.md

axic

Besides the formatting comment, I think it is fine merging this.

MicahZoltu

Should match template formatting: https://raw.githubusercontent.com/ethereum/EIPs/master/eip-template.md

Maybe I'm missing something, but this just looks like a definition for a new elliptic curve. I don't think the EIPs repository is really the right place for such things. Aren't there more standardized places to define a new elliptic curve where people with the experience to evaluate such things are more likely to look?

eip-draft_babyjubjub.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

axic · 2020-09-09T09:38:44Z

The validator still complains:

eip-2494.md: trailing whitespace

But honestly I'm not sure which line it is complaining about 😢

EIPS/eip-2494.md

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

EIPS/eip-2494.md

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

EIPS/eip-2494.md

axic · 2020-09-09T10:12:28Z

@bellesmarta my two last comment if you would like to respond to them so we can finally get this merged 😉

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

* Create eip-draft_babyjubjub.md * Update eip-draft_babyjubjub.md * Update eip-draft_babyjubjub.md * Update eip-draft_babyjubjub.md * Update eip-draft_babyjubjub.md Updated discussions-to link. * Update eip-draft_babyjubjub.md Added Go implementation of the curve. * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-draft_babyjubjub.md * Rename eip-draft_babyjubjub.md to eip-2494.md * Rename eip-2494.md to EIPS/eip-2494.md * Update EIPS/eip-2494.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update eip-2494.md * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> * Update EIPS/eip-2494.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: Alex Beregszaszi <alex@rtfs.hu> Co-authored-by: Micah Zoltu <micah@zoltu.net>

bellesmarta added 2 commits January 29, 2020 09:35

Create eip-draft_babyjubjub.md

ff2030e

Update eip-draft_babyjubjub.md

043e020

bellesmarta changed the title ~~eip-draft_babyjubjub.md~~ EIP: Baby Jubjub Elliptic Curve.md Jan 29, 2020

bellesmarta changed the title ~~EIP: Baby Jubjub Elliptic Curve.md~~ EIP: Baby Jubjub Elliptic Curve Jan 29, 2020

bellesmarta changed the title ~~EIP: Baby Jubjub Elliptic Curve~~ Draft EIP: Baby Jubjub Elliptic Curve Jan 29, 2020

bellesmarta changed the title ~~Draft EIP: Baby Jubjub Elliptic Curve~~ EIP: Baby Jubjub Elliptic Curve Jan 29, 2020

axic reviewed Jan 29, 2020

View reviewed changes

eip-draft_babyjubjub.md Outdated Show resolved Hide resolved

axic reviewed Jan 29, 2020

View reviewed changes

eip-draft_babyjubjub.md Outdated Show resolved Hide resolved

axic reviewed Jan 29, 2020

View reviewed changes

eip-draft_babyjubjub.md Outdated Show resolved Hide resolved

Update eip-draft_babyjubjub.md

9a819c9

axic reviewed Jan 29, 2020

View reviewed changes

jbaylina mentioned this pull request Jan 29, 2020

Discussions-to thread for EIP-2494 (Baby Jubjub Elliptic Curve) #2493

Closed

bellesmarta changed the title ~~EIP: Baby Jubjub Elliptic Curve~~ EIP-2494 Baby Jubjub Elliptic Curve Jan 29, 2020

bellesmarta added 3 commits January 29, 2020 13:05

Update eip-draft_babyjubjub.md

7ccdf09

Update eip-draft_babyjubjub.md

b3e12c9

Updated discussions-to link.

Update eip-draft_babyjubjub.md

41569d7

Added Go implementation of the curve.

Merge remote-tracking branch 'ethereum/master' into HEAD

c884b8d

axic reviewed Aug 28, 2020

View reviewed changes

eip-draft_babyjubjub.md Outdated Show resolved Hide resolved

axic approved these changes Aug 28, 2020

View reviewed changes

axic added the type: ERC label Aug 28, 2020

MicahZoltu suggested changes Aug 29, 2020

View reviewed changes

bellesmarta and others added 4 commits September 4, 2020 14:17

Update eip-draft_babyjubjub.md

da59b37

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Update eip-draft_babyjubjub.md

95b3626

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Update eip-draft_babyjubjub.md

cf9b168

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Update eip-draft_babyjubjub.md

4844702

Co-authored-by: Micah Zoltu <micah@zoltu.net>

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

bellesmarta and others added 8 commits September 9, 2020 11:55

Update EIPS/eip-2494.md

2110a6d

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

0e69ff8

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

27e5015

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

dda3975

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

eb67892

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

84afd06

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

cdf893a

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

631944d

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

Update EIPS/eip-2494.md

c46cafa

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

axic mentioned this pull request Sep 9, 2020

Improve the "trailing whitespace" error ethereum/eipv#20

Open

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

Update EIPS/eip-2494.md

1261504

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Outdated Show resolved Hide resolved

axic reviewed Sep 9, 2020

View reviewed changes

EIPS/eip-2494.md Show resolved Hide resolved

bellesmarta and others added 2 commits September 9, 2020 12:44

Update EIPS/eip-2494.md

26d6d0c

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

Update EIPS/eip-2494.md

d8b905d

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>

axic merged commit a6b84c8 into ethereum:master Sep 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-2494 Baby Jubjub Elliptic Curve #2494

EIP-2494 Baby Jubjub Elliptic Curve #2494

bellesmarta commented Jan 29, 2020 •

edited

Loading

axic commented Jan 29, 2020

axic Jan 29, 2020

bellesmarta Jan 29, 2020 •

edited

Loading

axic Jan 29, 2020

bellesmarta Jan 29, 2020

axic Jan 29, 2020

jbaylina commented Jan 29, 2020

paulmillr commented Feb 3, 2020

jbaylina commented Feb 3, 2020

paulmillr commented Feb 3, 2020 •

edited

Loading

axic left a comment

MicahZoltu left a comment

axic commented Sep 9, 2020

axic commented Sep 9, 2020

EIP-2494 Baby Jubjub Elliptic Curve #2494

EIP-2494 Baby Jubjub Elliptic Curve #2494

Conversation

bellesmarta commented Jan 29, 2020 • edited Loading

axic commented Jan 29, 2020

axic Jan 29, 2020

Choose a reason for hiding this comment

bellesmarta Jan 29, 2020 • edited Loading

Choose a reason for hiding this comment

axic Jan 29, 2020

Choose a reason for hiding this comment

bellesmarta Jan 29, 2020

Choose a reason for hiding this comment

axic Jan 29, 2020

Choose a reason for hiding this comment

jbaylina commented Jan 29, 2020

paulmillr commented Feb 3, 2020

jbaylina commented Feb 3, 2020

paulmillr commented Feb 3, 2020 • edited Loading

axic left a comment

Choose a reason for hiding this comment

MicahZoltu left a comment

Choose a reason for hiding this comment

axic commented Sep 9, 2020

axic commented Sep 9, 2020

bellesmarta commented Jan 29, 2020 •

edited

Loading

bellesmarta Jan 29, 2020 •

edited

Loading

paulmillr commented Feb 3, 2020 •

edited

Loading