Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2494 Baby Jubjub Elliptic Curve #2494

Open
wants to merge 6 commits into
base: master
from

Conversation

@bellesmarta
Copy link

bellesmarta commented Jan 29, 2020

This pull request stands for EIP-2494 proposing Baby Jubjub, a twisted Edwards elliptic curve designed to work inside zk-SNARK circuits in Ethereum. Contribute and follow the discussion thread at https://ethereum-magicians.org/t/eip-2494-baby-jubjub-elliptic-curve/3968.

bellesmarta added 2 commits Jan 29, 2020
@bellesmarta bellesmarta changed the title eip-draft_babyjubjub.md EIP: Baby Jubjub Elliptic Curve.md Jan 29, 2020
@bellesmarta bellesmarta changed the title EIP: Baby Jubjub Elliptic Curve.md EIP: Baby Jubjub Elliptic Curve Jan 29, 2020
@bellesmarta bellesmarta changed the title EIP: Baby Jubjub Elliptic Curve Draft EIP: Baby Jubjub Elliptic Curve Jan 29, 2020
@bellesmarta bellesmarta changed the title Draft EIP: Baby Jubjub Elliptic Curve EIP: Baby Jubjub Elliptic Curve Jan 29, 2020
@axic

This comment has been minimized.

Copy link
Member

axic commented Jan 29, 2020

Discussion thread in #2493.

eip-draft_babyjubjub.md Outdated Show resolved Hide resolved
eip-draft_babyjubjub.md Outdated Show resolved Hide resolved
eip-draft_babyjubjub.md Outdated Show resolved Hide resolved
eip: 2494
title: Baby Jubjub Elliptic Curve
authors: Barry WhiteHat (@barryWhiteHat), Marta Bellés (@bellesmarta), Jordi Baylina (@jbaylina)
discussions-to: https://github.com/ethereum/EIPs/pull/2494

This comment has been minimized.

Copy link
@axic

axic Jan 29, 2020

Member

This should link to https://github.com/ethereum/EIPs/issues/2493

This comment has been minimized.

Copy link
@bellesmarta

bellesmarta Jan 29, 2020

Author

Issue #2493 is closed. The discussion thread is moved to https://ethereum-magicians.org/t/eip-2494-baby-jubjub-elliptic-curve/3968.

This comment has been minimized.

Copy link
@axic

axic Jan 29, 2020

Member

FYI: At the time I wrote the comment, the issue was still open.

This comment has been minimized.

Copy link
@bellesmarta

bellesmarta Jan 29, 2020

Author

I opened and closed it now, could you check if it is okay now?

This comment has been minimized.

Copy link
@axic

axic Jan 29, 2020

Member

Hm? I wrote the comment at 10:16 GMT and the issue was first closed 10:45 GMT. I've only mentioned it for the record.

@jbaylina

This comment has been minimized.

Copy link
Contributor

jbaylina commented Jan 29, 2020

axic said:

This seems to be a specification of the new curve and not a direct integration into Ethereum. Because of that I would think perhaps some other mediums are better for publication if wider adoption is encouraged.

Perhaps IETF RFCs? A bunch of curves were specified as RFCs.

Right now, this curve is widelly used in the Ethereum space, so I think it make sense to have a standard here.

I don't think it's incompatible to start a RFC process, but this will require time and effort. So I think it's worthy to have a standarize as an ERC.

This is the base of other upcoming standards like EdDSA based on this curve, Baby Jub derivation key from an Ethereum Key, Signature aggregation, etc.

@bellesmarta bellesmarta changed the title EIP: Baby Jubjub Elliptic Curve EIP-2494 Baby Jubjub Elliptic Curve Jan 29, 2020
bellesmarta added 3 commits Jan 29, 2020
Updated discussions-to link.
Added Go implementation of the curve.
@paulmillr

This comment has been minimized.

Copy link

paulmillr commented Feb 3, 2020

Why isn't this bls12-381?

@jbaylina

This comment has been minimized.

Copy link
Contributor

jbaylina commented Feb 3, 2020

Currently, the only cure that is supported in Ethereum precompiled smart contract is BN-128.
For BLS12-381, you can check the ZCash JubJub curve.

@paulmillr

This comment has been minimized.

Copy link

paulmillr commented Feb 3, 2020

Understood. I wish there was an effort for precompiled bls12-381, since eth2 is using it. Interop is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.