Create EIP-4361: Sign-In with Ethereum#4361
Conversation
|
@awoie the PR is indeed in draft state, and therefore can't be merged right now. I appreciate everyone who signaled their support for it so far! We will discuss pretty important matters in the public community calls and attempt full resolution of any concerns prior to merge, but also we are on a timeline for delivery so this must be balanced too. Full details: https://login.xyz |
|
Hi, I have opened a thread here to continue all discussion: https://ethereum-magicians.org/t/eip-4361-sign-in-with-ethereum/7263/2 |
- Adds an out of scope section - Updates the language around domain-binding verification for wallets
Also addresses formatting issues from the CI.
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
All tests passed; auto-merging...(pass) eip-4361.md
|
|
Reminder to everyone: PR comments should mostly be limited to feedback required to get the EIP merged as a draft. Discussions about the specification itself should go in the discussions-to link found in the EIP header. |
Also remove trailing whitespaces
- RFC 4501 `dnsauthority` -> RFC 3986 `authority`. - Add SHOULD guideline for wallet implementers to check for simple phishing attacks. - Credits to @SamWilsn.
|
Hi @MicahZoltu, I believe we are ready for review and merge here. Thank you for your patience. |
|
I only handle Core EIPs. @axic or @lightclient are the ones who handle ERCs. |
- EIP URIs changed to relative paths - Paragraph from motivation section moved to `discussions-to` - Discussion & Acknowledgements section moved to `discussions-to` - Forwards Compatibility section moved under Rationale section - Additional Resources section moved to `discussions-to`
|
@lightclient thank you for your keen eye, in my latest commit I hope to have addressed all the points you brought up. Ready for another review when you're ready. Please let me know if you'd prefer that I squash everything into a single commit. |
|
Hi @lightclient, following up on this PR. Please let me know if there are any further necessary changes. I appreciate your review to date! |
lightclient
left a comment
lightclient
left a comment
There was a problem hiding this comment.
Thanks for your patience and for addressing that feedback. LGTM.
* Create EIP-4361: Sign-In with Ethereum * Update discussion link to ethereum-magicians.org * Little fixes to the grammar and examples * Out of Scope Section, Updates to Language - Adds an out of scope section - Updates the language around domain-binding verification for wallets * Add links to RFCs and EIPs * Fix broken TBD link * Fix typos and trailing spaces * Resolve remaining WIP items Also addresses formatting issues from the CI. * updated additional resources and forwards compatibility * Clarify the definition of `\n` in `statement` Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Fix chain ID placement in examples Also remove trailing whitespaces * Improvements to grammar and security guidelines - RFC 4501 `dnsauthority` -> RFC 3986 `authority`. - Add SHOULD guideline for wallet implementers to check for simple phishing attacks. - Credits to @SamWilsn. * Improve Conformance to EIP-1 - EIP URIs changed to relative paths - Paragraph from motivation section moved to `discussions-to` - Discussion & Acknowledgements section moved to `discussions-to` - Forwards Compatibility section moved under Rationale section - Additional Resources section moved to `discussions-to` Co-authored-by: Simon Bihel <simon.bihel@spruceid.com> Co-authored-by: Gregory Rocco <gregoryrocco1226@gmail.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
|
spruceid:eip-4361 |
16 participants
This is the draft PR for Sign-In with Ethereum. Development is happening in the open on community calls.
Latest updates about the project can be found at https://login.xyz
TODO: