Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Reference ERCs by ERC-X #5273

Merged
merged 10 commits into from Feb 5, 2023

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jul 15, 2022

Changes EIP-1 to force ERCs to be referenced as ERC-X instead of EIP-X.

NOTE: I honestly don't actually care if this change is implemented (in fact, I lean slightly towards keeping ERC references as EIP-X). I am just making this PR so that the appropriate action can be taken immediately once a consensus is reached.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 15, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1.md

classification
updateEIP
  • Changes to EIP 1 require at least 5 unique approvals from editors; there's currently 2 approvals; the remaining editors are @axic, @lightclient, @gcolvin

@MicahZoltu
Copy link
Contributor

We should turn off EIPW for EIP-1. I don't particularly care on this one either, I'll defer to others.

@SamWilsn
Copy link
Contributor

SamWilsn commented Jul 16, 2022

We should turn off EIPW for EIP-1.

Done in #5278

@lightclient
Copy link
Member

As one of the main proponents for referring to EIPs in the ERC category, I'm a 👍 on this.

@Pandapip1 Pandapip1 closed this Jul 28, 2022
@Pandapip1 Pandapip1 reopened this Jul 28, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 28, 2022 14:53
@Pandapip1 Pandapip1 closed this Aug 2, 2022
auto-merge was automatically disabled August 2, 2022 18:29

Pull request was closed

@Pandapip1 Pandapip1 reopened this Aug 2, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 2, 2022 18:29
@github-actions github-actions bot removed the updateEIP label Aug 2, 2022
@Pandapip1 Pandapip1 closed this Aug 8, 2022
auto-merge was automatically disabled August 8, 2022 20:16

Pull request was closed

@Pandapip1 Pandapip1 reopened this Aug 8, 2022
@eth-bot eth-bot enabled auto-merge (squash) August 8, 2022 20:16
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am once again reiterating my dislike for this change 🤣

If we're determined to go ahead with it, I prefer this wording.

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@Pandapip1 Pandapip1 removed this from the Manual Merge Queue milestone Sep 16, 2022
@Pandapip1 Pandapip1 added the e-consensus Waiting on editor consensus label Sep 16, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 1, 2022
@Pandapip1
Copy link
Member Author

@lightclient are you still happy with these changes?

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 3, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 17, 2022
@Pandapip1
Copy link
Member Author

I think this is still something @lightclient and @gcolvin want

@lightclient
Copy link
Member

We really need to do this. Many people in the community are becoming confused by our backtracking of ERC => EIP.

@poojaranjan
Copy link
Contributor

Just for the record, I am not a fan of this idea, as I think that all other Standard Track EIPs are still documented as EIP and so should be Standard Track ERC. Community are free to call EIP-20 or ERC-20 as per their convenience.

However, if people agree to go with changing the documentation in EIP-1 as ERC-x, I'd like to see the change in the .md file of respective proposals to avoid confusion.

image

@SamWilsn
Copy link
Contributor

SamWilsn commented Oct 19, 2022

As promised, here's the eipw implementation: ethereum/eipw#48


I'm still opposed.

@github-actions github-actions bot removed the w-stale Waiting on activity label Oct 20, 2022
@xinbenlv
Copy link
Contributor

xinbenlv commented Nov 16, 2022

Documenting discussion: this issue was discussed on EIPIP Meeting 69. The resolution is

  1. @lightclient and @xinbenlv expressed in favor
  2. @SamWilsn continue to feel against, but is now open to further discuss in discord, if there is a strong consensus in favor of this PR, he will not block it.

@poojaranjan and everyone correct me if I was wrong

@Pandapip1
Copy link
Member Author

Pandapip1 commented Nov 17, 2022

I am also -0 (not in favor, but not blocking).

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 26, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 27, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😾

@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Feb 1, 2023
@SamWilsn SamWilsn merged commit 817635a into ethereum:master Feb 5, 2023
@Pandapip1 Pandapip1 deleted the reference-by-erc branch February 5, 2023 18:19
iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
* Make ERCs referenced as ERC-X

* While I'm at it, change should to must

* Make the two sentences a bit more similar

* Rephrase

* The bike shed has been built

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

---------

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP editors should explain that ERC was renamed to EIP How should EIPs should be referenced?
7 participants