Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Scheme-Handler Discovery Option for Wallets #7039

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

SamWilsn
Copy link
Contributor

No description provided.

@SamWilsn SamWilsn requested a review from eth-bot as a code owner May 17, 2023 16:12
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-interface labels May 17, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 17, 2023

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot changed the title Add SHADOW Add EIP: Scheme-Handler Discovery Option for Wallets May 17, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 17, 2023

This proposal (affectionately known as SHADOW) is an alternative to [EIP-1193](./eip-1193.md) for wallet discovery in web browsers that requires no special permissions. Web pages intending to open a connection to a wallet inject an `iframe` tag pointing at a well-known scheme. Communication between the page and the wallet uses the `postMessage` API.

## Motivation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something, but can’t we utilise 6963 to solve the motivation for this? I mean, if a user has already requested perms for a wallet, can’t we just switch the current active provider from the built up providers array?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can even request perms by switching the active provider too*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the motivation to try and distinguish this proposal from 6963. Using a protocol handler reduces the required extension permissions significantly, and lets non-extension wallets connect.

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightclient lightclient merged commit 31fe728 into ethereum:master Jul 26, 2023
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants