Skip to content

Add EIP: Separate Metadata Section for EOF - #9100

Merged
eth-bot merged 8 commits into
ethereum:masterfrom
kuzdogan:eof-metadata-eip
Dec 17, 2024
Merged

eth-bot merged 8 commits into
ethereum:masterfrom
kuzdogan:eof-metadata-eip

Conversation

@kuzdogan

@kuzdogan kuzdogan commented Dec 6, 2024

Copy link
Copy Markdown
Member

No description provided.

@kuzdogan
kuzdogan requested a review from eth-bot as a code owner December 6, 2024 14:09
@github-actions github-actions Bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Dec 6, 2024
@eth-bot

ghost commented Dec 6, 2024 •

Copy link
Copy Markdown
Collaborator

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Dec 6, 2024
@eth-bot eth-bot changed the title Add EIP draft: Separate Metadata Section for EOF Add EIP: Separate Metadata Section for EOF Dec 6, 2024
@github-actions github-actions Bot added the w-ci Waiting on CI to pass label Dec 6, 2024
Comment thread EIPS/eip-eof-metadata.md Outdated
Comment thread EIPS/eip-eof-metadata.md Outdated
title: Separate Metadata Section for EOF
description: Introduce a new separate metadata section to the EOF
author: Kaan Uzdogan (@kuzdogan), Marco Castignoli (@marcocastignoli), Manuel Wedler (@manuelwedler)
discussions-to: <URL>

ghost Dec 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a discussions topic in Eth Magicians using the template: https://ethereum-magicians.org/c/eips/5

ghost Dec 9, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Comment thread EIPS/eip-eof-metadata.md Outdated
Kaan Uzdoğan and others added 3 commits December 9, 2024 17:18
Co-authored-by: Manuel Wedler <34456797+manuelwedler@users.noreply.github.com>
@kuzdogan kuzdogan changed the title Add EIP: Separate Metadata Section for EOF Add EIP-7834: Separate Metadata Section for EOF Dec 9, 2024
@github-actions

ghost commented Dec 9, 2024

Copy link
Copy Markdown

The commit fe8cdb5 (as a parent of bbb3183) contains errors.
Please inspect the Run Summary for details.

@eth-bot eth-bot changed the title Add EIP-7834: Separate Metadata Section for EOF Add EIP: Separate Metadata Section for EOF Dec 11, 2024
@github-actions github-actions Bot removed the w-ci Waiting on CI to pass label Dec 11, 2024
Comment thread EIPS/eip-7834.md Outdated

## Motivation

It is desirable to include metadata in contract's bytecode for various reasons. For instance, both the Solidity and Vyper compilers by default include the language and compiler version used to compile. Solidity additionally includes the IPFS or the Swarm hash of the Solidity contract metadata.json file, and the experimental Solidity flag. The current (pre-EOF) practice is to append this CBOR encoded metadata section in the contract's runtime bytecode, followed by the 2 bytes length of the CBOR encoded bytes.

ghost Dec 12, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, in Vyper 0.4.1 (to be released), the integrity hash (using sha256 under to the hood) is now put into the initcode (not runtime code) (vyperlang/vyper#4234) to preserve bytecode space of the runtime code. That's also a smart way to deal with it ;)

ghost Dec 16, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks for the info

@eth-bot
eth-bot enabled auto-merge (squash) December 17, 2024 09:20

ghost left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot
eth-bot merged commit 821ffeb into ethereum:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants