Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eth_chainId #4810

Closed
axic opened this issue Jan 26, 2018 · 1 comment

Comments

@axic
Copy link
Member

commented Jan 26, 2018

See ethereum/EIPs#695 and paritytech/parity-ethereum#6329 (merged into parity).

This would be useful for the upcoming ewasm testnet & tooling around it.

@chfast chfast added the help wanted label Jan 26, 2018
@gumb0 gumb0 added the rpc label Jan 26, 2018
@halfalicious

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2018

I'd like to take this one 😀 A couple of quick questions:

  • Is there any documentation for regenerating libweb3jsonrpc\Ethface.h after I've added the new chainId function to eth.json? I've tried running jsonrpcstub eth.json --cpp-server=dev::rpc::EthFace but there are some differences between my generated file and the existing one (e.g. my EthFace class extends jsonrpc::AbstractServer<EthFace> rather than ServerInterface<EthFace>). Apologies if this is a naive question, I haven't used jsonrpcstub before.
  • Same goes for tests\unittests\libweb3jsonrpc\WebThreeStubClient.h - is there any documentation for how to properly regenerate this? Additionally, which json file do I need to update? I don't see one in tests\unittests\libweb3jsonrpc

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.