New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for MIT license and external contributors #2789

Merged
merged 4 commits into from Aug 12, 2015

Conversation

Projects
None yet
4 participants
@LefterisJP
Contributor

LefterisJP commented Aug 11, 2015

No description provided.

README.md Outdated
### Contributing
All new contributions are added under the MIT License. Please refer to the `LICENCSE` file in the root directory.
To state that you accept this fact for all of your PRs please add yourself to the list of external contributors

This comment has been minimized.

@chriseth

chriseth Aug 11, 2015

Contributor

Perhaps abstract from the technical side of how contributions are introduced into the codebase (i.e. replace PRs by contributions), or at least spell out PR.

This comment has been minimized.

@LefterisJP

LefterisJP Aug 11, 2015

Contributor

good point

README.md Outdated
like in the example below.
#### External Contributors
I hereby place all my contributions in this file under an MIT

This comment has been minimized.

@chriseth

chriseth Aug 11, 2015

Contributor

file -> codebase?

README.md Outdated
### Contributing
All new contributions are added under the MIT License. Please refer to the `LICENCSE` file in the root directory.

This comment has been minimized.

@subtly

subtly Aug 11, 2015

Member

LICENSE

@LefterisJP LefterisJP force-pushed the LefterisJP:mit_license_mention branch from c58324d to 0e27533 Aug 11, 2015

@gavofyork

This comment has been minimized.

Contributor

gavofyork commented Aug 12, 2015

windows failing?

@LefterisJP

This comment has been minimized.

Contributor

LefterisJP commented Aug 12, 2015

WoW, something actually depended on this file. Helped us find a Typo 👍

gavofyork pushed a commit that referenced this pull request Aug 12, 2015

Gav Wood
Merge pull request #2789 from LefterisJP/mit_license_mention
Wording for MIT license and external contributors

@gavofyork gavofyork merged commit 0e1ae31 into ethereum:develop Aug 12, 2015

4 checks passed

Linux C++ evmjit pull requests DEV build done.
Details
Linux C++ pull requests DEV build done.
Details
OSX C++ pull requests DEV build done.
Details
Windows C++ pull requests DEV build done.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment