New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 684: contract creation on nonempty code or nonzero nonce fails. #4384

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
5 participants
@pirapira
Member

pirapira commented Aug 23, 2017

Note this change is applied for all blocks from block number zero.

@winsvega

This comment has been minimized.

Show comment
Hide comment
@winsvega

winsvega Aug 23, 2017

Contributor

So once and for all. address collision result in OOG, on all forks including future updates.

For transactions that will run parallel FCFS rules are applied

Contributor

winsvega commented Aug 23, 2017

So once and for all. address collision result in OOG, on all forks including future updates.

For transactions that will run parallel FCFS rules are applied

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 23, 2017

Member

FCFS?

Member

pirapira commented Aug 23, 2017

FCFS?

@winsvega

This comment has been minimized.

Show comment
Hide comment
@winsvega

winsvega Aug 23, 2017

Contributor

FirstComeFirstServed

Contributor

winsvega commented Aug 23, 2017

FirstComeFirstServed

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 23, 2017

Member

I see. Well, transactions have nonces.

Member

pirapira commented Aug 23, 2017

I see. Well, transactions have nonces.

@winsvega

This comment has been minimized.

Show comment
Hide comment
@winsvega

winsvega Aug 23, 2017

Contributor

there was an EIP about different transaction proccessing

Contributor

winsvega commented Aug 23, 2017

there was an EIP about different transaction proccessing

pirapira added some commits Aug 23, 2017

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 24, 2017

Member

Rebased.

Member

pirapira commented Aug 24, 2017

Rebased.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 24, 2017

Codecov Report

Merging #4384 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4384      +/-   ##
===========================================
- Coverage    67.75%   67.73%   -0.02%     
===========================================
  Files          303      303              
  Lines        23207    23205       -2     
===========================================
- Hits         15723    15718       -5     
- Misses        7484     7487       +3
Impacted Files Coverage Δ
libethereum/Executive.cpp 59.84% <100%> (-0.31%) ⬇️
libethereum/Account.h 90.9% <0%> (-4.55%) ⬇️
libethereum/State.cpp 76.6% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a73ed0...91832e8. Read the comment docs.

codecov-io commented Aug 24, 2017

Codecov Report

Merging #4384 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4384      +/-   ##
===========================================
- Coverage    67.75%   67.73%   -0.02%     
===========================================
  Files          303      303              
  Lines        23207    23205       -2     
===========================================
- Hits         15723    15718       -5     
- Misses        7484     7487       +3
Impacted Files Coverage Δ
libethereum/Executive.cpp 59.84% <100%> (-0.31%) ⬇️
libethereum/Account.h 90.9% <0%> (-4.55%) ⬇️
libethereum/State.cpp 76.6% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a73ed0...91832e8. Read the comment docs.

@winsvega

merge branch at the test repo at the same time

@pirapira pirapira merged commit 9bd9318 into develop Aug 24, 2017

5 checks passed

codecov/patch 100% of diff hit (target 50%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +32.24% compared to 3a73ed0
Details
codecov/project/app Absolute coverage decreased by -0.02% but relative coverage increased by +36.93% compared to 3a73ed0
Details
codecov/project/tests 76.31% remains the same compared to 3a73ed0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pirapira pirapira deleted the address-collision-fails branch Aug 24, 2017

@cdetrio

This comment has been minimized.

Show comment
Hide comment
@cdetrio
Member

cdetrio commented Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment