New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Drop db module #4560

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
3 participants
@chfast
Collaborator

chfast commented Sep 27, 2017

No description provided.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 27, 2017

Codecov Report

Merging #4560 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4560      +/-   ##
===========================================
+ Coverage    63.24%   63.31%   +0.07%     
===========================================
  Files          368      363       -5     
  Lines        30513    30447      -66     
  Branches      2750     2749       -1     
===========================================
- Hits         19298    19278      -20     
+ Misses       11032    10990      -42     
+ Partials       183      179       -4
Impacted Files Coverage Δ
libdevcore/MemoryDB.cpp 92.53% <0%> (-4.13%) ⬇️
test/tools/fuzzTesting/createRandomTest.cpp 72.47% <0%> (-0.92%) ⬇️
ethkey/main.cpp 0% <0%> (ø) ⬆️
libethereum/BlockQueue.h 71.6% <0%> (+2.46%) ⬆️
libethereum/BlockQueue.cpp 47.9% <0%> (+4.19%) ⬆️
libethereum/VerifiedBlock.h 68.75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cf591...105d1ff. Read the comment docs.

codecov-io commented Sep 27, 2017

Codecov Report

Merging #4560 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4560      +/-   ##
===========================================
+ Coverage    63.24%   63.31%   +0.07%     
===========================================
  Files          368      363       -5     
  Lines        30513    30447      -66     
  Branches      2750     2749       -1     
===========================================
- Hits         19298    19278      -20     
+ Misses       11032    10990      -42     
+ Partials       183      179       -4
Impacted Files Coverage Δ
libdevcore/MemoryDB.cpp 92.53% <0%> (-4.13%) ⬇️
test/tools/fuzzTesting/createRandomTest.cpp 72.47% <0%> (-0.92%) ⬇️
ethkey/main.cpp 0% <0%> (ø) ⬆️
libethereum/BlockQueue.h 71.6% <0%> (+2.46%) ⬆️
libethereum/BlockQueue.cpp 47.9% <0%> (+4.19%) ⬆️
libethereum/VerifiedBlock.h 68.75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cf591...105d1ff. Read the comment docs.

@pirapira

Looks good to me.

@pirapira pirapira merged commit 6bd758c into develop Sep 27, 2017

6 of 7 checks passed

codecov/project/tests 77.29% (-0.01%) compared to e5cf591
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e5cf591...105d1ff
Details
codecov/project 63.31% (+0.07%) compared to e5cf591
Details
codecov/project/app 55% (+0.09%) compared to e5cf591
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pirapira pirapira deleted the drop-db-rpc branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment