New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable framing in devp2p for all protocol versions #4594

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@gumb0
Member

gumb0 commented Oct 11, 2017

This was preventing from succesfully communicating with devp2p v5 geth nodes

@gumb0 gumb0 added the needs review label Oct 11, 2017

@gumb0 gumb0 requested review from pirapira and chfast Oct 11, 2017

Show outdated Hide outdated libp2p/Session.h
@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Oct 11, 2017

Collaborator

Let's ship this change. Later we should probably drop this feature.

Collaborator

chfast commented Oct 11, 2017

Let's ship this change. Later we should probably drop this feature.

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Oct 11, 2017

Collaborator

CC @gluk256.

Collaborator

chfast commented Oct 11, 2017

CC @gluk256.

@chfast

chfast approved these changes Oct 11, 2017

@chfast chfast merged commit 9378810 into develop Oct 11, 2017

3 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: Linux-Clang5 Your tests passed on CircleCI!
Details
ci/circleci: Linux-GCC6-Debug Your tests passed on CircleCI!
Details
ci/circleci: macOS-XCode9 Your tests passed on CircleCI!
Details

@chfast chfast deleted the disable-devp2p-framing branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment