Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Move ClientBase::m_tq into Client #4610

Merged
merged 1 commit into from Oct 25, 2017
Merged

Move ClientBase::m_tq into Client #4610

merged 1 commit into from Oct 25, 2017

Conversation

pirapira
Copy link
Member

Fixes #4608

@codecov-io
Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #4610 into develop will decrease coverage by 4.26%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4610      +/-   ##
===========================================
- Coverage    57.44%   53.18%   -4.27%     
===========================================
  Files         1085     1612     +527     
  Lines        55490    69319   +13829     
  Branches      3658     7127    +3469     
===========================================
+ Hits         31878    36864    +4986     
- Misses       22584    31239    +8655     
- Partials      1028     1216     +188
Impacted Files Coverage Δ
libethereum/ClientBase.cpp 2.23% <ø> (-4.69%) ⬇️
libethereum/Client.h 69.56% <0%> (+13.56%) ⬆️
test/tools/libtestutils/FixedClient.h 0% <0%> (ø) ⬆️
libethereum/ClientBase.h 35.29% <100%> (+1.96%) ⬆️
libethereum/Client.cpp 30.75% <55.17%> (+4.26%) ⬆️
...Install/include/boost/algorithm/string/replace.hpp 0% <0%> (-100%) ⬇️
...4/Install/include/boost/range/detail/safe_bool.hpp 0% <0%> (-100%) ⬇️
...stall/include/boost/algorithm/string/formatter.hpp 0% <0%> (-100%) ⬇️
deps/include/jsonrpccpp/common/exception.h 0% <0%> (-100%) ⬇️
...all/include/boost/algorithm/string/find_format.hpp 0% <0%> (-100%) ⬇️
... and 907 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2409d7e...83f97cd. Read the comment docs.

@pirapira
Copy link
Member Author

https://travis-ci.org/ethereum/cpp-ethereum/jobs/289579510 says illegal instruction:

unknown location(0): fatal error: in "GeneralStateTests/stRandom2": signal: illegal operand; address of failing instruction: 0x00baba43

/home/travis/build/ethereum/cpp-ethereum/test/tools/libtesteth/ImportTest.cpp(211): last checkpoint

@chfast Do you know the fix?

@chfast
Copy link
Collaborator

chfast commented Oct 19, 2017

The fix is here: #4605

@pirapira
Copy link
Member Author

Thanks!

@pirapira pirapira force-pushed the moving_m_tq branch 2 times, most recently from 56a8144 to ea07a47 Compare October 23, 2017 09:34
Copy link
Member

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chfast
Copy link
Collaborator

chfast commented Oct 24, 2017

Merge?

@pirapira pirapira merged commit b35296b into develop Oct 25, 2017
@pirapira pirapira deleted the moving_m_tq branch October 25, 2017 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants