New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better command line in ethkey and eth #4635

Merged
merged 8 commits into from Dec 13, 2017

Conversation

Projects
None yet
5 participants
@demon1999
Contributor

demon1999 commented Oct 28, 2017

Better comand line in ethkey and eth

@demon1999 demon1999 changed the title from Develop2 to Better comand line in ethkey Oct 28, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 28, 2017

Codecov Report

Merging #4635 into develop will decrease coverage by 2.43%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4635      +/-   ##
===========================================
- Coverage    60.88%   58.44%   -2.44%     
===========================================
  Files          343      338       -5     
  Lines        27111    25677    -1434     
  Branches      2781     3141     +360     
===========================================
- Hits         16506    15008    -1498     
+ Misses        9621     9616       -5     
- Partials       984     1053      +69
Impacted Files Coverage Δ
eth/MinerAux.h 0% <0%> (ø) ⬆️
ethkey/main.cpp 0% <0%> (ø) ⬆️
eth/main.cpp 0% <0%> (ø) ⬆️
ethkey/KeyAux.h 0% <0%> (ø) ⬆️
test/unittests/libethereum/BlockQueue.cpp 5.17% <0%> (-94.83%) ⬇️
libethereum/StateImporter.h 0% <0%> (-66.67%) ⬇️
libethereum/VerifiedBlock.h 7.14% <0%> (-52.86%) ⬇️
libethereum/BlockQueue.h 30.13% <0%> (-34.25%) ⬇️
libethereum/SnapshotStorage.h 0% <0%> (-25%) ⬇️
libdevcore/TrieHash.h 80% <0%> (-20%) ⬇️
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117eeca...4b0bb1c. Read the comment docs.

codecov-io commented Oct 28, 2017

Codecov Report

Merging #4635 into develop will decrease coverage by 2.43%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4635      +/-   ##
===========================================
- Coverage    60.88%   58.44%   -2.44%     
===========================================
  Files          343      338       -5     
  Lines        27111    25677    -1434     
  Branches      2781     3141     +360     
===========================================
- Hits         16506    15008    -1498     
+ Misses        9621     9616       -5     
- Partials       984     1053      +69
Impacted Files Coverage Δ
eth/MinerAux.h 0% <0%> (ø) ⬆️
ethkey/main.cpp 0% <0%> (ø) ⬆️
eth/main.cpp 0% <0%> (ø) ⬆️
ethkey/KeyAux.h 0% <0%> (ø) ⬆️
test/unittests/libethereum/BlockQueue.cpp 5.17% <0%> (-94.83%) ⬇️
libethereum/StateImporter.h 0% <0%> (-66.67%) ⬇️
libethereum/VerifiedBlock.h 7.14% <0%> (-52.86%) ⬇️
libethereum/BlockQueue.h 30.13% <0%> (-34.25%) ⬇️
libethereum/SnapshotStorage.h 0% <0%> (-25%) ⬇️
libdevcore/TrieHash.h 80% <0%> (-20%) ⬇️
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117eeca...4b0bb1c. Read the comment docs.

@gumb0 gumb0 requested review from chfast and gumb0 Oct 28, 2017

Show outdated Hide outdated eth/MinerAux.h
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated ethkey/main.cpp

@gumb0 gumb0 added the needs review label Oct 30, 2017

@demon1999

This comment has been minimized.

Show comment
Hide comment
@demon1999

demon1999 Oct 31, 2017

Contributor

fixed

Contributor

demon1999 commented Oct 31, 2017

fixed

@demon1999 demon1999 changed the title from Better comand line in ethkey to Better command line in ethkey Oct 31, 2017

@demon1999 demon1999 changed the title from Better command line in ethkey to Better command line in ethkey and eth Oct 31, 2017

@gumb0 gumb0 self-requested a review Nov 23, 2017

@gumb0

First some simple requests, mostly to fix formatting

Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated ethkey/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated eth/main.cpp
@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Nov 30, 2017

Member

I guess rlp/main.cpp shouldn't be part of this PR, as it's already in #4639 ? Remove it from here then

Member

gumb0 commented Nov 30, 2017

I guess rlp/main.cpp shouldn't be part of this PR, as it's already in #4639 ? Remove it from here then

Show outdated Hide outdated eth/main.cpp
Show outdated Hide outdated ethkey/main.cpp
@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 8, 2017

Member

Squashed everything into one commit and rebased on develop. Tried not to loose anything.

Member

gumb0 commented Dec 8, 2017

Squashed everything into one commit and rebased on develop. Tried not to loose anything.

Show outdated Hide outdated ethkey/main.cpp
Show outdated Hide outdated ethkey/main.cpp

gumb0 added some commits Dec 8, 2017

Remove some deprecated options. Remove multiletter option aliases as …
…boost.program_options doesn't support them. Help output improvements.
@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 11, 2017

Member

For anyone interested here's the summary of non-backwards compatible changes affecting working command line options:

  • --testnet removed; use --ropsten instead;
  • undocumented --kill-blockchain removed; use --kill or -K instead;
  • --admin was not working, but undocumented --json-admin was working instead - this is fixed, now only --admin is working;
  • --author removed; use --address instead;
  • --public removed; use --public-ip instead;
  • --listen-port removed; use --listen instead;
  • --datadir and undocumented --path removed; use --db-path or -d instead.
  • import (without dashes) removed, use --import instead.
  • export (without dashes) removed, use --export instead.
  • undocumented --independent removed.
Member

gumb0 commented Dec 11, 2017

For anyone interested here's the summary of non-backwards compatible changes affecting working command line options:

  • --testnet removed; use --ropsten instead;
  • undocumented --kill-blockchain removed; use --kill or -K instead;
  • --admin was not working, but undocumented --json-admin was working instead - this is fixed, now only --admin is working;
  • --author removed; use --address instead;
  • --public removed; use --public-ip instead;
  • --listen-port removed; use --listen instead;
  • --datadir and undocumented --path removed; use --db-path or -d instead.
  • import (without dashes) removed, use --import instead.
  • export (without dashes) removed, use --export instead.
  • undocumented --independent removed.

gumb0 added some commits Dec 11, 2017

Remove "import" and "export" options (without dashes) and handle "--i…
…mport" and ""--export" as other regular options
@gumb0

gumb0 approved these changes Dec 12, 2017

Show outdated Hide outdated eth/main.cpp
@chfast

chfast approved these changes Dec 12, 2017

@holiman

This comment has been minimized.

Show comment
Hide comment
Contributor

holiman commented Dec 13, 2017

@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 13, 2017

Member

@holiman Also this one https://github.com/karalabe/hive/blob/master/clients/cpp-ethereum:develop/eth.sh#L161
We recently removed HTTP server from eth, now instead of --json-rpc --json-rpc-port 8545 --admin-via-http you need to run scripts/jsonrpcproxy.py

Member

gumb0 commented Dec 13, 2017

@holiman Also this one https://github.com/karalabe/hive/blob/master/clients/cpp-ethereum:develop/eth.sh#L161
We recently removed HTTP server from eth, now instead of --json-rpc --json-rpc-port 8545 --admin-via-http you need to run scripts/jsonrpcproxy.py

@gumb0 gumb0 merged commit 19bf103 into ethereum:develop Dec 13, 2017

4 of 9 checks passed

codecov/patch CI failed.
Details
codecov/project CI failed.
Details
codecov/project/app CI failed.
Details
codecov/project/tests CI failed.
Details
ci/circleci: macOS-XCode9 Your tests failed on CircleCI
Details
ci/circleci: Linux-Clang5 Your tests passed on CircleCI!
Details
ci/circleci: Linux-GCC6-Debug Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@holiman

This comment has been minimized.

Show comment
Hide comment
@holiman

holiman Dec 13, 2017

Contributor

Can that be started before eth, or does eth need to create the ipc file first?

Contributor

holiman commented Dec 13, 2017

Can that be started before eth, or does eth need to create the ipc file first?

@holiman

This comment has been minimized.

Show comment
Hide comment
@holiman

holiman Dec 13, 2017

Contributor

@karalabe does hive use the HTTP endpoints, or the ipc endpoints when the simulator queries the nodes?

Contributor

holiman commented Dec 13, 2017

@karalabe does hive use the HTTP endpoints, or the ipc endpoints when the simulator queries the nodes?

@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 13, 2017

Member

@holiman I think eth should be started first

Member

gumb0 commented Dec 13, 2017

@holiman I think eth should be started first

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Dec 13, 2017

Collaborator

It should not matter. In case it does let me know.

Collaborator

chfast commented Dec 13, 2017

It should not matter. In case it does let me know.

@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 13, 2017

Member

@chfast It looks like it doesn't find ipc socket when starting it wihout runnin eth:

> scripts/jsonrpcproxy.py
Traceback (most recent call last):
  File "scripts/jsonrpcproxy.py", line 156, in <module>
    run()
  File "scripts/jsonrpcproxy.py", line 151, in run
    proxy = Proxy(args.proxy_url, args.backend_path)
  File "scripts/jsonrpcproxy.py", line 113, in __init__
    self.sock = get_ipc_socket(self.backend_address)
  File "scripts/jsonrpcproxy.py", line 69, in get_ipc_socket
    sock.connect(ipc_path)
FileNotFoundError: [Errno 2] No such file or directory
Member

gumb0 commented Dec 13, 2017

@chfast It looks like it doesn't find ipc socket when starting it wihout runnin eth:

> scripts/jsonrpcproxy.py
Traceback (most recent call last):
  File "scripts/jsonrpcproxy.py", line 156, in <module>
    run()
  File "scripts/jsonrpcproxy.py", line 151, in run
    proxy = Proxy(args.proxy_url, args.backend_path)
  File "scripts/jsonrpcproxy.py", line 113, in __init__
    self.sock = get_ipc_socket(self.backend_address)
  File "scripts/jsonrpcproxy.py", line 69, in get_ipc_socket
    sock.connect(ipc_path)
FileNotFoundError: [Errno 2] No such file or directory
@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Dec 13, 2017

Collaborator

Ok. I will fix it later on.

Collaborator

chfast commented Dec 13, 2017

Ok. I will fix it later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment