New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better command line in ethvm #4638

Merged
merged 9 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@demon1999
Contributor

demon1999 commented Oct 31, 2017

better command line in Options.cpp

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 31, 2017

Codecov Report

Merging #4638 into develop will increase coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #4638     +/-   ##
==========================================
+ Coverage    53.38%   53.59%   +0.2%     
==========================================
  Files         1611     1638     +27     
  Lines        69237    70500   +1263     
  Branches      7091     7248    +157     
==========================================
+ Hits         36963    37781    +818     
- Misses       31060    31432    +372     
- Partials      1214     1287     +73
Impacted Files Coverage Δ
libdevcore/FixedHash.h 93.68% <ø> (+0.61%) ⬆️
ethvm/main.cpp 0% <0%> (ø) ⬆️
...Install/include/boost/asio/detail/wait_handler.hpp 0% <0%> (-100%) ⬇️
...tall/include/boost/asio/detail/task_io_service.hpp 0% <0%> (-100%) ⬇️
...tall/include/boost/asio/detail/impl/socket_ops.ipp 0% <0%> (-100%) ⬇️
State.h 0% <0%> (-100%) ⬇️
...cb74/Install/include/boost/asio/detail/wait_op.hpp 0% <0%> (-100%) ⬇️
...5/9d3cb74/Install/include/boost/core/addressof.hpp 0% <0%> (-100%) ⬇️
...t/home/classic/iterator/impl/position_iterator.ipp 0% <0%> (-100%) ⬇️
...it/home/classic/iterator/position_iterator_fwd.hpp 0% <0%> (-100%) ⬇️
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4100691...8be148f. Read the comment docs.

codecov-io commented Oct 31, 2017

Codecov Report

Merging #4638 into develop will increase coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #4638     +/-   ##
==========================================
+ Coverage    53.38%   53.59%   +0.2%     
==========================================
  Files         1611     1638     +27     
  Lines        69237    70500   +1263     
  Branches      7091     7248    +157     
==========================================
+ Hits         36963    37781    +818     
- Misses       31060    31432    +372     
- Partials      1214     1287     +73
Impacted Files Coverage Δ
libdevcore/FixedHash.h 93.68% <ø> (+0.61%) ⬆️
ethvm/main.cpp 0% <0%> (ø) ⬆️
...Install/include/boost/asio/detail/wait_handler.hpp 0% <0%> (-100%) ⬇️
...tall/include/boost/asio/detail/task_io_service.hpp 0% <0%> (-100%) ⬇️
...tall/include/boost/asio/detail/impl/socket_ops.ipp 0% <0%> (-100%) ⬇️
State.h 0% <0%> (-100%) ⬇️
...cb74/Install/include/boost/asio/detail/wait_op.hpp 0% <0%> (-100%) ⬇️
...5/9d3cb74/Install/include/boost/core/addressof.hpp 0% <0%> (-100%) ⬇️
...t/home/classic/iterator/impl/position_iterator.ipp 0% <0%> (-100%) ⬇️
...it/home/classic/iterator/position_iterator_fwd.hpp 0% <0%> (-100%) ⬇️
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4100691...8be148f. Read the comment docs.

Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
Show outdated Hide outdated ethvm/main.cpp
@demon1999

This comment has been minimized.

Show comment
Hide comment
@demon1999

demon1999 Nov 5, 2017

Contributor

Fixed

Contributor

demon1999 commented Nov 5, 2017

Fixed

@gumb0 gumb0 self-requested a review Nov 23, 2017

Show outdated Hide outdated ethvm/main.cpp

gumb0 added some commits Nov 27, 2017

Make boost.program_options automatically convert string to Address in…
…stead of parsing an optiona as a string and converting manually.
@gumb0

gumb0 approved these changes Nov 27, 2017

@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Nov 27, 2017

Member

Sorry for the long silence, mostly everyone were on holidays after devcon.

This one seems fine to me now, I'll try to help yo with other PRs

Member

gumb0 commented Nov 27, 2017

Sorry for the long silence, mostly everyone were on holidays after devcon.

This one seems fine to me now, I'll try to help yo with other PRs

@demon1999

This comment has been minimized.

Show comment
Hide comment
@demon1999

demon1999 Nov 28, 2017

Contributor

Thank you for you help.

Contributor

demon1999 commented Nov 28, 2017

Thank you for you help.

@gumb0 gumb0 merged commit 3c119f3 into ethereum:develop Nov 28, 2017

7 of 9 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
codecov/project/tests 82.38% (-0.49%) compared to 4100691
Details
ci/circleci: Linux-Clang5 Your tests passed on CircleCI!
Details
ci/circleci: Linux-GCC6-Debug Your tests passed on CircleCI!
Details
ci/circleci: macOS-XCode9 Your tests passed on CircleCI!
Details
codecov/project 53.59% (+0.2%) compared to 4100691
Details
codecov/project/app 49.4% (+0.29%) compared to 4100691
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Nov 28, 2017

Member

Congratulations, the first one merged! 🎉

Member

gumb0 commented Nov 28, 2017

Congratulations, the first one merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment