New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Drop HTTP server #4657

Merged
merged 8 commits into from Dec 5, 2017

Conversation

Projects
None yet
4 participants
@chfast
Collaborator

chfast commented Nov 22, 2017

Depends on #4673.

@chfast chfast requested review from gumb0 and chriseth Nov 22, 2017

@chfast chfast added the in progress label Nov 22, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 22, 2017

Codecov Report

Merging #4657 into develop will decrease coverage by 6.84%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4657      +/-   ##
===========================================
- Coverage    60.36%   53.52%   -6.85%     
===========================================
  Files         1084     1605     +521     
  Lines        54947    69456   +14509     
  Branches      3569     7137    +3568     
===========================================
+ Hits         33171    37174    +4003     
- Misses       20646    31062   +10416     
- Partials      1130     1220      +90
Impacted Files Coverage Δ
libweb3jsonrpc/Eth.h 20% <ø> (-5%) ⬇️
libweb3jsonrpc/Eth.cpp 6.66% <ø> (+0.55%) ⬆️
eth/main.cpp 0% <0%> (ø)
.../Install/include/boost/asio/detail/object_pool.hpp 0% <0%> (-100%) ⬇️
.../boost/asio/detail/task_io_service_thread_info.hpp 0% <0%> (-100%) ⬇️
...include/boost/date_time/time_resolution_traits.hpp 0% <0%> (-100%) ⬇️
...e/boost/asio/detail/eventfd_select_interrupter.hpp 0% <0%> (-100%) ⬇️
...all/include/boost/asio/impl/handler_alloc_hook.ipp 0% <0%> (-100%) ⬇️
...l/include/boost/asio/detail/impl/epoll_reactor.hpp 0% <0%> (-100%) ⬇️
...t/home/classic/iterator/impl/position_iterator.ipp 0% <0%> (-100%) ⬇️
... and 929 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f82f18...4457b93. Read the comment docs.

codecov-io commented Nov 22, 2017

Codecov Report

Merging #4657 into develop will decrease coverage by 6.84%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4657      +/-   ##
===========================================
- Coverage    60.36%   53.52%   -6.85%     
===========================================
  Files         1084     1605     +521     
  Lines        54947    69456   +14509     
  Branches      3569     7137    +3568     
===========================================
+ Hits         33171    37174    +4003     
- Misses       20646    31062   +10416     
- Partials      1130     1220      +90
Impacted Files Coverage Δ
libweb3jsonrpc/Eth.h 20% <ø> (-5%) ⬇️
libweb3jsonrpc/Eth.cpp 6.66% <ø> (+0.55%) ⬆️
eth/main.cpp 0% <0%> (ø)
.../Install/include/boost/asio/detail/object_pool.hpp 0% <0%> (-100%) ⬇️
.../boost/asio/detail/task_io_service_thread_info.hpp 0% <0%> (-100%) ⬇️
...include/boost/date_time/time_resolution_traits.hpp 0% <0%> (-100%) ⬇️
...e/boost/asio/detail/eventfd_select_interrupter.hpp 0% <0%> (-100%) ⬇️
...all/include/boost/asio/impl/handler_alloc_hook.ipp 0% <0%> (-100%) ⬇️
...l/include/boost/asio/detail/impl/epoll_reactor.hpp 0% <0%> (-100%) ⬇️
...t/home/classic/iterator/impl/position_iterator.ipp 0% <0%> (-100%) ⬇️
... and 929 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f82f18...4457b93. Read the comment docs.

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Nov 27, 2017

Contributor

While I welcome the general direction of removing the HTTP server, it is important for debugging solidity tests that remix has debugging access to eth. Is there a simple ipc-http-bridge we can use?

Contributor

chriseth commented Nov 27, 2017

While I welcome the general direction of removing the HTTP server, it is important for debugging solidity tests that remix has debugging access to eth. Is there a simple ipc-http-bridge we can use?

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Nov 29, 2017

Collaborator

No there is no ipc-http-bridge.
Also @gumb0 reported that HTTP is needed for ethstats at the moment, so I will have to address this too before removing HTTP server.

How solidity is using HTTP transport? Can't it use Unix sockets?

Collaborator

chfast commented Nov 29, 2017

No there is no ipc-http-bridge.
Also @gumb0 reported that HTTP is needed for ethstats at the moment, so I will have to address this too before removing HTTP server.

How solidity is using HTTP transport? Can't it use Unix sockets?

@chfast chfast added gotissues and removed in progress labels Nov 29, 2017

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Nov 29, 2017

Contributor

Solidity does use IPC, I only use HTTP to inspect test failures from remix.

Contributor

chriseth commented Nov 29, 2017

Solidity does use IPC, I only use HTTP to inspect test failures from remix.

@chfast chfast added the rpc label Nov 29, 2017

@gumb0

gumb0 approved these changes Dec 4, 2017

@chfast chfast added needs review and removed gotissues labels Dec 4, 2017

chfast added some commits Nov 22, 2017

@chfast chfast merged commit 57985f4 into develop Dec 5, 2017

4 of 5 checks passed

ci/circleci: macOS-XCode9 Your tests failed on CircleCI
Details
ci/circleci: Linux-Clang5 Your tests passed on CircleCI!
Details
ci/circleci: Linux-GCC6-Debug Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chfast chfast removed the needs review label Dec 5, 2017

@chfast chfast deleted the rpc-no-http branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment