New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving out snapshot through Warp protocol #4710

Merged
merged 4 commits into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@gumb0
Member

gumb0 commented Dec 18, 2017

  1. Copy snapshot into data dir after importing it.
  2. Support server-side of Warp protocol, so that cpp nodes could download snapshots from other cpp nodes.

Snapshot files won't ever change and the node will give out the same snapshot all the time.
Further improvements could support periodic generation of our own snapshots.

@gumb0 gumb0 added the in progress label Dec 18, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 19, 2017

Codecov Report

Merging #4710 into develop will increase coverage by 1.28%.
The diff coverage is 33.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4710      +/-   ##
===========================================
+ Coverage    59.51%   60.79%   +1.28%     
===========================================
  Files          342      347       +5     
  Lines        27026    27298     +272     
  Branches      2838     2865      +27     
===========================================
+ Hits         16084    16597     +513     
+ Misses        9981     9705     -276     
- Partials       961      996      +35

codecov-io commented Dec 19, 2017

Codecov Report

Merging #4710 into develop will increase coverage by 1.28%.
The diff coverage is 33.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4710      +/-   ##
===========================================
+ Coverage    59.51%   60.79%   +1.28%     
===========================================
  Files          342      347       +5     
  Lines        27026    27298     +272     
  Branches      2838     2865      +27     
===========================================
+ Hits         16084    16597     +513     
+ Misses        9981     9705     -276     
- Partials       961      996      +35
@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Dec 19, 2017

Member

Applied clang-format in the separate commit

Member

gumb0 commented Dec 19, 2017

Applied clang-format in the separate commit

@gumb0 gumb0 removed the in progress label Dec 19, 2017

gumb0 added some commits Dec 14, 2017

Lower snapshot importing log messages verbosity to 8, because level 9…
… produces too many messages from BlockHeader class during blocks import

@gumb0 gumb0 requested review from pirapira and chfast Dec 20, 2017

@pirapira

Looks good to me.

@gumb0 gumb0 merged commit 730bbdf into develop Dec 21, 2017

8 of 9 checks passed

codecov/patch 33.76% of diff hit (target 50%)
Details
ci/circleci: Linux-Clang5 Your tests passed on CircleCI!
Details
ci/circleci: Linux-GCC6-Debug Your tests passed on CircleCI!
Details
ci/circleci: macOS-XCode9 Your tests passed on CircleCI!
Details
codecov/project 60.79% (+1.28%) compared to 088a34a
Details
codecov/project/app 52.76% (+0.42%) compared to 088a34a
Details
codecov/project/tests 78.89% (+3.29%) compared to 088a34a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gumb0 gumb0 deleted the snapshot-server branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment