Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposer_id to BeaconBlock #1601

Closed
djrtwo opened this issue Jan 28, 2020 · 3 comments
Closed

Add proposer_id to BeaconBlock #1601

djrtwo opened this issue Jan 28, 2020 · 3 comments
Labels
general:enhancement New feature or request

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Jan 28, 2020

I didn't realize #1339 had been closed! Creating this issue for some fresh eyes. This is something I'd definitely like to revisit and maybe have auditors look at this month.

See #1339 for the original description of the issue.

The tldr is that without a proposer_id and a way for a quick signature verification on an incoming block, an attacker can create blocks with some amount of skip slots that require database look ups and state transitions to even validate the proposer signature. In the current case, that attacker doesn't even need to be in the validator set.

By adding the proposer_id we at least reduce the set that can craft such blocks to the validators and limit them to a 1 per slot allowance (due to gossip conditions and slashing conditions). This rate limit combined with peer scoring (and dropping!) at least begins to bound this problem.

@hwwhww hwwhww added the general:enhancement New feature or request label Jan 31, 2020
@protolambda
Copy link
Collaborator

protolambda commented Feb 5, 2020

You have my support for this change. And prefer proposer_index over proposer_id to be more consistent with the other places where we use validator indices.

@terencechain
Copy link
Contributor

terencechain commented Feb 5, 2020

+1 on this change. This will result in better client code

@protolambda
Copy link
Collaborator

protolambda commented Mar 11, 2020

Closing this issue, the proposer id (index) has been introduced in #1626, to be featured in upcoming v0.11.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@djrtwo @hwwhww @protolambda @terencechain and others