Fix Capella genesis testing tool #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate_from_eth1` helper
etan-status
approved these changes
Jul 15, 2022
|
Thanks, this indeed fixes the problems with |
ralexstokes
reviewed
Jul 15, 2022
specs/capella/beacon-chain.md
Outdated
| state.next_sync_committee = get_next_sync_committee(state) | ||
|
|
||
| # Initialize the execution payload header | ||
| # If empty, will initialize a chain that has not yet gone through the Merge transition |
There was a problem hiding this comment.
this is an interesting point.... is there any value in testing a capella net pre-merge?
I think its an open question but given that we are starting this beacon chain at cappella, it feels like testing a pre-merge state is something that would never hit in a public-facing testnet or mainnet
There was a problem hiding this comment.
agreed. I'd remove this comment.
djrtwo
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_genesis_state: should have updatedprevious_versionandcurrent_versioninitialize_beacon_state_from_eth1