Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a few bugs with deposit verification. #388

Merged
merged 9 commits into from
Jan 10, 2019
Merged

Fixes a few bugs with deposit verification. #388

merged 9 commits into from
Jan 10, 2019

Commits on Jan 9, 2019

  1. Add clarifying comment about where this index is coming from

    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    5f19622 View commit details
    Browse the repository at this point in the history

  2. Fixes bugs with description of deposit verification. 

    1. The order of the `deposit_data` serialization does not match the current
Vyper contract. The description now matches that serialization.

2. The `deposit.merkle_tree_index` was not being used (at least explicitly) so
the text now reflects which inputs are to be used for which parameters in the
pseudocode spec that follows.

3. There seems to be a bug where we want the initial leaf to be the `hash` of
the `DepositData`, not the data itself. The text now reflects this requirement.
    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    dff84c0 View commit details
    Browse the repository at this point in the history

  3. Update 0_beacon-chain.md

    @JustinDrake @ralexstokes
    JustinDrake authored and ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    4ea4302 View commit details
    Browse the repository at this point in the history

  4. Reorder type so the ssz serialization matches other uses 

    There is an order based on the Vyper deposit contract which should be maintained
here. There is also a reference to it when processing `Deposit` messages.

This commit corrects the order here so all serializations will match.
    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    6f5a865 View commit details
    Browse the repository at this point in the history

  5. Add missing deposit root when performing Merkle verification

    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    c5de2fe View commit details
    Browse the repository at this point in the history

  6. Use the correct name for the amount field

    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    f49f7ed View commit details
    Browse the repository at this point in the history

  7. Fix variable name that was lost in botched rebase

    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    7a6854a View commit details
    Browse the repository at this point in the history

  8. Broadcast merkle_tree_index in lieu of the deposit count

    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    d628346 View commit details
    Browse the repository at this point in the history

  9. Truncate the index into the Merkle tree to bytes[8] 

    The beacon chain expects a `uint64` in part to avoid big-int computation.
This commit updates the `Deposit` log so that it broadcasts data of the
appropriate size.
    @ralexstokes
    ralexstokes committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    4cf06d9 View commit details
    Browse the repository at this point in the history